Skip to content

fix(datepicker): toggle throwing an error if datepicker is not defined on init #15256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

crisbeto
Copy link
Member

Fixes the mat-datepicker-toggle throwing an error if the datepicker undefined on init. We already have guards for this in all of the other cases, but it was missing in this one.

…d on init

Fixes the `mat-datepicker-toggle` throwing an error if the `datepicker` undefined on init. We already have guards for this in all of the other cases, but it was missing in this one.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 20, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner February 20, 2019 22:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 20, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 21, 2019
@josephperrott josephperrott merged commit 1c503ff into angular:master Mar 5, 2019
josephperrott pushed a commit that referenced this pull request Mar 5, 2019
…d on init (#15256)

Fixes the `mat-datepicker-toggle` throwing an error if the `datepicker` undefined on init. We already have guards for this in all of the other cases, but it was missing in this one.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants