Skip to content

fix(autocomplete): panel not closing on IE when selecting an option with an empty string display value #9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2018

Conversation

crisbeto
Copy link
Member

Fixes the autocomplete panel reopening on IE11 when the user selects an option whose display value is an empty string.

Fixes #9479.

@crisbeto crisbeto requested a review from kara as a code owner January 21, 2018 13:00
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 21, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Jan 24, 2018

It's possible that checking activeElement may start to make some tests fail (if people are faking input events). We'll see how the presubmit goes.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 24, 2018
@crisbeto crisbeto force-pushed the 9479/autocomplete-ie-close branch from 02e17e2 to db1e584 Compare January 24, 2018 18:03
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 24, 2018
@crisbeto
Copy link
Member Author

The activeElement check was already there, this only introduces the check for the value.

@tinayuangao
Copy link
Contributor

@crisbeto please rebase. Thanks!

…ith an empty string display value

Fixes the autocomplete panel reopening on IE11 when the user selects an option whose display value is an empty string.

Fixes angular#9479.
@crisbeto crisbeto force-pushed the 9479/autocomplete-ie-close branch from db1e584 to 12a77df Compare February 2, 2018 22:10
@crisbeto
Copy link
Member Author

crisbeto commented Feb 2, 2018

Rebased.

@tinayuangao tinayuangao merged commit 95ffe37 into angular:master Feb 3, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mat-autocomplete doesn't close using displayWith under IE11
4 participants