Skip to content

feat(tabs): Allow tab ink bar positioning to be determined with a provided method #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2018
Merged

feat(tabs): Allow tab ink bar positioning to be determined with a provided method #9972

merged 1 commit into from
Mar 27, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added pr: needs review target: minor This PR is targeted for the next minor release labels Feb 15, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 15, 2018
jelbourn
jelbourn approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 16, 2018
@mmalerba mmalerba added this to the 6.0 milestone Mar 2, 2018
@josephperrott josephperrott force-pushed the ink-bar branch 2 times, most recently from 2ae1d66 to 4da9b2b Compare March 23, 2018 16:30
@josephperrott josephperrott merged commit 02f5256 into angular:master Mar 27, 2018
@josephperrott josephperrott deleted the ink-bar branch March 27, 2018 15:24
@crisbeto crisbeto mentioned this pull request Apr 2, 2018
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @jelbourn @googlebot @mmalerba