test(select): update static query tests #15320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some tests that will fail under Ivy, because they depend on static queries.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Feb 26, 2019
Updates the root causes for the `MatSelect` failures. A few of them were fixed by angular/components#15320.
benlesh
pushed a commit
to angular/angular
that referenced
this pull request
Feb 27, 2019
Updates the root causes for the `MatSelect` failures. A few of them were fixed by angular/components#15320. PR Close #28989
kara
pushed a commit
to kara/material2
that referenced
this pull request
Mar 7, 2019
Fixes some tests that will fail under Ivy, because they depend on static queries.
kara
pushed a commit
to kara/material2
that referenced
this pull request
Mar 7, 2019
Fixes some tests that will fail under Ivy, because they depend on static queries.
kara
pushed a commit
to kara/material2
that referenced
this pull request
Mar 7, 2019
Fixes some tests that will fail under Ivy, because they depend on static queries.
josephperrott
pushed a commit
that referenced
this pull request
Mar 7, 2019
Fixes some tests that will fail under Ivy, because they depend on static queries.
Suresh918
pushed a commit
to Suresh918/material2
that referenced
this pull request
Apr 15, 2019
Fixes some tests that will fail under Ivy, because they depend on static queries.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some tests that will fail under Ivy, because they depend on static queries.
Note: I went with adding
static: trueon some of them, because we have some cases that are testing specifically that the select won't throw if it certain properties are accessed in a static query.