docs(developers): add basic DEVELOPER.md and update README #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
suggested changes
Jan 27, 2017
|
|
||
| ``` | ||
| npm run format | ||
| ``` |
There was a problem hiding this comment.
You can also run linting with $(npm bin)/gulp lint
|
|
||
| `webdriver-js-extender` extends selenium-webdriver to add Appium commands. | ||
| github.com/angular/webdriver-js-extender | ||
|
|
heathkit
reviewed
Jan 27, 2017
|
|
||
| Travis runs e2e tests via SauceLabs against a variety of browsers. The essential browsers run a | ||
| more complete test suite. We also run a set of smoke tests against a larger set of browsers, | ||
| which is allowed to fail. This is due to flakiness in IE, Safari and older browser versions. |
There was a problem hiding this comment.
Maybe call out the specific conf files here - ciFull, ciSmoke, etc. Also what's up with BrowserStack? Is that intended to work? It seems to flake slightly more often than Travis.
heathkit
reviewed
Jan 27, 2017
| which is allowed to fail. This is due to flakiness in IE, Safari and older browser versions. | ||
|
|
||
| Circle CI runs a slightly modified version of `npm test` in a single VM. It installs | ||
| the browsers it needs locally. Circle CI runs unit tests and a set of e2e tests against Chrome. |
There was a problem hiding this comment.
Maybe mention why we have two systems? Circle limits you by running instance time, so it's better to keep the Saucelabs tests running on Travis. Also, stdout and stderr logs of all processes as well as a tcpdump of webdriver traffic are all available in the CircleCI artifacts for each build.
juliemr
force-pushed
the
documentabulous
branch
from
7dc63e0
to
7915852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.