-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs(developers): add basic DEVELOPER.md and update README #4026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small additions I'd like to see in this PR
|
||
``` | ||
npm run format | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also run linting with $(npm bin)/gulp lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
`webdriver-js-extender` extends selenium-webdriver to add Appium commands. | ||
github.com/angular/webdriver-js-extender | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no webdriver-manager
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh. Added.
|
||
Travis runs e2e tests via SauceLabs against a variety of browsers. The essential browsers run a | ||
more complete test suite. We also run a set of smoke tests against a larger set of browsers, | ||
which is allowed to fail. This is due to flakiness in IE, Safari and older browser versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call out the specific conf files here - ciFull, ciSmoke, etc. Also what's up with BrowserStack? Is that intended to work? It seems to flake slightly more often than Travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
which is allowed to fail. This is due to flakiness in IE, Safari and older browser versions. | ||
|
||
Circle CI runs a slightly modified version of `npm test` in a single VM. It installs | ||
the browsers it needs locally. Circle CI runs unit tests and a set of e2e tests against Chrome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention why we have two systems? Circle limits you by running instance time, so it's better to keep the Saucelabs tests running on Travis. Also, stdout and stderr logs of all processes as well as a tcpdump of webdriver traffic are all available in the CircleCI artifacts for each build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
7dc63e0
to
7915852
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me
No description provided.