This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix(plugins): do not force ManagedPromise in plugins.ts #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliemr
approved these changes
Jan 31, 2017
|
Approved, with requisite wishing we actually had a test to demonstrate the problem. |
sjelin
force-pushed
the
ONE_LAST_PROMISE
branch
from
8d8f267
to
74993ce
Compare
|
@juliemr test added, will merge when CI is done |
sjelin
force-pushed
the
ONE_LAST_PROMISE
branch
from
74993ce
to
c72863f
Compare
|
hahahaha that was three hours ago - never decide to do a bit of debugging before you go to sleep 😂 (also fun fact: node doesn't warn you about circular references it just randomly gives your empty objects and lets you figure out what's gone wrong) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.