This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(doc-gen): fix the doc gen script #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get |
juliemr
reviewed
Jan 31, 2017
scripts/generate-docs.sh
Outdated
|
|
||
| # Generate files | ||
| echo "Building the website..." | ||
| cd website | ||
| npm run build |
There was a problem hiding this comment.
This should also run npm install here.
There was a problem hiding this comment.
Sorry about that. Looks like my clean from a couple lines up wasn't as thorough as I though, so I didn't catch this. Fixed.
|
I also get a lot of error messages but they don't seem to actually stop docs from being generated. Notably: I think this is due to old versions of some sub dependencies, probably from dgeni. |
|
@juliemr those definitely don't sound like a problem with the script itself. |
|
This looks pretty good to me and runs without completely falling over. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never ran into the annotation problem @juliemr talked about, so please test this on your local machines