This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(examples): Fix TSC issues with exampleTypescript #4132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some small updates to TS config and TS related deps to allow compilation with the version of TS installed by the example.
I'm still familiarizing myself with the TS ecosystem and the way things should be done, so please let me know if there's a convention that I've missed here.
Issues Resolved
Jasmine typing issues (see DefinitelyTyped/DefinitelyTyped#14569 for more details), Pinning the jasmine typings prevents the following compilation error:
We could also resolve this by pinning the typescript depedency of the example to
^2.2.0
Missing
Promise
definitions. Updating the target to es6 (which seems sane to me since we are now node 6+) prevents issues with Promise typings: