-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
We should be very careful when updating dependencies like Webdriver. In addition, you've commented out some linting related code without an explanation. Could you provide some reasoning behind these changes? If not, i'll go ahead and close this PR in 3 days. Thanks! |
Hello Nick, about the commented lines, both commands (npm install, tsc) produce no output so checking that to determine if there was an error is breaking this test on my side, please let me know if I'm missing something about it |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
cla signed |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Any news on this? What is needed to get it included? The older Selenium version in Protractor is a problem for running tests in Chrome Headless. |
Is this still relevant or can this (stale) PR closed? Because 0fbc2c0 landed and bumped the version of selenium-webdriver. |
Already updated to 3.6.0. Close the PR |
No description provided.