Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

update selenium-webdriver #4265

Closed
wants to merge 2 commits into from
Closed

update selenium-webdriver #4265

wants to merge 2 commits into from

Conversation

benitogf
Copy link

@benitogf benitogf commented May 5, 2017

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@NickTomlin
Copy link
Contributor

We should be very careful when updating dependencies like Webdriver. In addition, you've commented out some linting related code without an explanation.

Could you provide some reasoning behind these changes? If not, i'll go ahead and close this PR in 3 days. Thanks!

@NickTomlin NickTomlin closed this May 6, 2017
@NickTomlin NickTomlin reopened this May 6, 2017
@benitogf
Copy link
Author

benitogf commented May 7, 2017

Hello Nick, about the commented lines, both commands (npm install, tsc) produce no output so checking that to determine if there was an error is breaking this test on my side, please let me know if I'm missing something about it

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@benitogf
Copy link
Author

benitogf commented May 7, 2017

cla signed

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@csvan
Copy link

csvan commented Sep 26, 2017

Any news on this? What is needed to get it included? The older Selenium version in Protractor is a problem for running tests in Chrome Headless.

@timbru31
Copy link

Is this still relevant or can this (stale) PR closed? Because 0fbc2c0 landed and bumped the version of selenium-webdriver.

@qiyigg
Copy link
Contributor

qiyigg commented Dec 15, 2017

Already updated to 3.6.0. Close the PR

@qiyigg qiyigg closed this Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants