This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
feat(example): add examples of usage protractor framework with angular-material components; #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Examples for #4883 |
CrispusDH
reviewed
Jul 20, 2018
| jasmineNodeOpts: { | ||
| defaultTimeoutInterval: 30000 | ||
| } | ||
| }; |
There was a problem hiding this comment.
End Of File (EOF). Or it is not necessary?
There was a problem hiding this comment.
Hi, @CrispusDH ! Thanks for the review) Actually, I tried to follow code style of examples. But I can add it if necessary.
qiyigg
reviewed
Jul 20, 2018
example/angular_material/conf.js
Outdated
| ], | ||
|
|
||
| // Disable promise manager because we are going to use async/await | ||
| SELENIUM_PROMISE_MANAGER: false, |
|
Looks good to me. Could you please update the commit title based on guideline: |
IgorSasovets
changed the title
|
Hi, @qiyigg ! Thanks for the review) I added mentioned fixes. |
qiyigg
changed the title
|
merged, thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples of usage protractor for testing angular-material components.