This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(test): move locators_spec.js off of the control flow #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
locators_spec
branch
2 times, most recently
from
d947b54
to
96f9633
Compare
|
Reference #4995 |
cnishina
commented
Nov 7, 2018
spec/basic/locators_spec.js
Outdated
| }); | ||
|
|
||
| it('should allow custom expectations to expect an element', function() { | ||
| it('should allow custom expectations to expect an element', async() => { |
There was a problem hiding this comment.
Not sure what I'm doing... 🤷♂️
There was a problem hiding this comment.
This is passing because this is now an xit. This should be turned back on when removing the jasmine-wd node module. I will add this into the main issue to track this.
cnishina
force-pushed
the
locators_spec
branch
2 times, most recently
from
b0bd8c2
to
2528d59
Compare
heathkit
approved these changes
Nov 8, 2018
cnishina
force-pushed
the
locators_spec
branch
from
2528d59
to
34abdf8
Compare
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Dec 19, 2018
cnishina
added a commit
to cnishina/protractor
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.