Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

chore(test): move restartBrowserBetweenTests off of the control flow #5020

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

cnishina
Copy link
Member

@cnishina cnishina commented Nov 8, 2018

No description provided.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@cnishina cnishina changed the base branch from master to selenium4 November 8, 2018 21:59
@cnishina cnishina changed the title Restart chore(test): move restartBrowserBetweenTests off of the control flow Nov 8, 2018
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@cnishina cnishina merged commit 7b77acf into angular:selenium4 Nov 9, 2018
cnishina added a commit to cnishina/protractor that referenced this pull request Dec 19, 2018
cnishina added a commit to cnishina/protractor that referenced this pull request Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants