Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

chore(tests): fix spec/ng2/timeout_spec test #5067

Merged
merged 2 commits into from
Nov 29, 2018
Merged

chore(tests): fix spec/ng2/timeout_spec test #5067

merged 2 commits into from
Nov 29, 2018

Conversation

cnishina
Copy link
Member

No description provided.

@CrispusDH
Copy link
Contributor

in file .../spec/ng2/async_spec.js you should change line 76 (add await):
from: const text = timeout.$('.val').getText();
to: const text = await timeout.$('.val').getText();

@cnishina
Copy link
Member Author

Thanks! I remember making this change in the 95 file PR.

@cnishina cnishina merged commit 39ed5a3 into angular:selenium4 Nov 29, 2018
cnishina added a commit to cnishina/protractor that referenced this pull request Dec 19, 2018
@cnishina
chore(tests): fix spec/ng2/timeout_spec test (angular#5067)
ff1c6d2
cnishina added a commit to cnishina/protractor that referenced this pull request Mar 23, 2019
@cnishina
chore(tests): fix spec/ng2/timeout_spec test (angular#5067)
0c6b134
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CrispusDH CrispusDH CrispusDH approved these changes

@heathkit heathkit heathkit approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cnishina @CrispusDH @heathkit @googlebot