This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Integrate Dart Formatter directly into ts2dart for cleaner output #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
this should not be necessary, TypeScript should find this just from the require('dart-style');.
|
ptal |
lib/main.ts
Outdated
There was a problem hiding this comment.
nit: call it dartStyle or so?
|
Looks pretty good. Could you check out my other comment above? Also: in this project's |
and more readable test cases.
|
Merged as c43031f. Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and more readable test cases.
Not sure if the way I integrated dart-style.d.ts is the right but it works.