Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Commit 029b659

Browse files
alan-agius4vikerman
authored andcommitted
fix(hapi-engine): update schematic for server.ts
1 parent abe57e0 commit 029b659

File tree

8 files changed

+23
-85
lines changed

8 files changed

+23
-85
lines changed

integration/hapi-engine-ivy/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@
3232
"hapi": "file:../../node_modules/hapi",
3333
"inert": "5.1.0",
3434
"rxjs": "file:../../node_modules/rxjs",
35-
"zone.js": "file:../../node_modules/zone.js",
36-
"vision": "5.4.4"
35+
"zone.js": "file:../../node_modules/zone.js"
3736
},
3837
"devDependencies": {
3938
"@angular-devkit/build-angular": "0.900.0-next.4",
@@ -42,7 +41,6 @@
4241
"@types/inert": "file:../../node_modules/@types/inert",
4342
"@types/node": "file:../../node_modules/@types/node",
4443
"@types/jasmine": "file:../../node_modules/@types/jasmine",
45-
"@types/vision": "file:../../node_modules/@types/vision",
4644
"codelyzer": "5.1.0",
4745
"concurrently": "3.1.0",
4846
"jasmine-core": "3.4.0",

integration/hapi-engine-ivy/server.ts

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ import 'zone.js/dist/zone-node';
22

33
import { ngHapiEngine } from '@nguniversal/hapi-engine';
44
import * as inert from 'inert';
5-
import * as vision from 'vision';
65
import { Request, Server, ResponseToolkit } from 'hapi';
76
import { join } from 'path';
87

98
import { AppServerModule } from './src/main.server';
9+
import { readFileSync } from 'fs';
1010

1111
// Hapi server
1212
async function run(): Promise<void> {
@@ -22,25 +22,16 @@ async function run(): Promise<void> {
2222
},
2323
});
2424

25-
await server.register(vision);
26-
server.views({
27-
engines: {
28-
html : {
29-
compile: (document: string) => (req: Request) => ngHapiEngine({
30-
bootstrap: AppServerModule,
31-
document,
32-
req,
33-
})
34-
}
35-
},
36-
path: distFolder,
37-
});
25+
const document = readFileSync(join(distFolder, 'index.html'), 'utf-8');
3826

3927
server.route({
4028
method: 'GET',
4129
path: '/{path*}',
42-
handler: (req: Request, res: ResponseToolkit) =>
43-
res.view('index', req)
30+
handler: (req: Request) => ngHapiEngine({
31+
bootstrap: AppServerModule,
32+
document,
33+
req,
34+
})
4435
});
4536

4637
await server.register(inert);

integration/hapi-engine-ve/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@
3232
"hapi": "file:../../node_modules/hapi",
3333
"inert": "5.1.0",
3434
"rxjs": "file:../../node_modules/rxjs",
35-
"zone.js": "file:../../node_modules/zone.js",
36-
"vision": "5.4.4"
35+
"zone.js": "file:../../node_modules/zone.js"
3736
},
3837
"devDependencies": {
3938
"@angular-devkit/build-angular": "0.900.0-next.4",
@@ -42,7 +41,6 @@
4241
"@types/inert": "file:../../node_modules/@types/inert",
4342
"@types/node": "file:../../node_modules/@types/node",
4443
"@types/jasmine": "file:../../node_modules/@types/jasmine",
45-
"@types/vision": "file:../../node_modules/@types/vision",
4644
"codelyzer": "5.1.0",
4745
"concurrently": "3.1.0",
4846
"jasmine-core": "3.4.0",

integration/hapi-engine-ve/server.ts

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@ import 'zone.js/dist/zone-node';
22

33
import { ngHapiEngine } from '@nguniversal/hapi-engine';
44
import * as inert from 'inert';
5-
import * as vision from 'vision';
65
import { Request, Server, ResponseToolkit } from 'hapi';
76
import { join } from 'path';
8-
7+
import { readFileSync } from 'fs';
98
import { AppServerModuleNgFactory } from './src/main.server';
109

1110
// Hapi server
@@ -22,25 +21,16 @@ async function run(): Promise<void> {
2221
},
2322
});
2423

25-
await server.register(vision);
26-
server.views({
27-
engines: {
28-
html : {
29-
compile: (document: string) => (req: Request) => ngHapiEngine({
30-
bootstrap: AppServerModuleNgFactory,
31-
document,
32-
req,
33-
})
34-
}
35-
},
36-
path: distFolder,
37-
});
24+
const document = readFileSync(join(distFolder, 'index.html'), 'utf-8');
3825

3926
server.route({
4027
method: 'GET',
4128
path: '/{path*}',
42-
handler: (req: Request, res: ResponseToolkit) =>
43-
res.view('index', req)
29+
handler: (req: Request) => ngHapiEngine({
30+
bootstrap: AppServerModuleNgFactory,
31+
document,
32+
req,
33+
})
4434
});
4535

4636
await server.register(inert);

modules/hapi-engine/schematics/install/files/__serverFileName@stripTsExtension__.ts

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import 'zone.js/dist/zone-node';
22

33
import { ngHapiEngine } from '@nguniversal/hapi-engine';
44
import * as inert from 'inert';
5-
import * as vision from 'vision';
65
import { Request, Server, ResponseToolkit } from 'hapi';
76
import { join } from 'path';
7+
import { readFileSync } from 'fs';
88

99
import { AppServerModule } from './src/<%= stripTsExtension(main) %>';
1010

@@ -22,25 +22,16 @@ async function run(): Promise<void> {
2222
},
2323
});
2424

25-
await server.register(vision);
26-
server.views({
27-
engines: {
28-
html : {
29-
compile: (document: string) => (req: Request) => ngHapiEngine({
30-
bootstrap: AppServerModule,
31-
document,
32-
req,
33-
})
34-
}
35-
},
36-
path: distFolder,
37-
});
25+
const document = readFileSync(join(distFolder, 'index.html'), 'utf-8');
3826

3927
server.route({
4028
method: 'GET',
4129
path: '/{path*}',
42-
handler: (req: Request, res: ResponseToolkit) =>
43-
res.view('index', req)
30+
handler: (req: Request) => ngHapiEngine({
31+
bootstrap: AppServerModule,
32+
document,
33+
req,
34+
})
4435
});
4536

4637
await server.register(inert);

modules/hapi-engine/schematics/install/index.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,6 @@ function addDependencies(options: UniversalOptions): Rule {
5050
name: 'inert',
5151
version: '^5.1.0',
5252
});
53-
addPackageJsonDependency(host, {
54-
type: NodeDependencyType.Default,
55-
name: 'vision',
56-
version: '^5.4.4',
57-
});
58-
addPackageJsonDependency(host, {
59-
type: NodeDependencyType.Dev,
60-
name: '@types/vision',
61-
version: '^5.4.4',
62-
});
6353
addPackageJsonDependency(host, {
6454
type: NodeDependencyType.Dev,
6555
name: '@types/inert',

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@
103103
"@types/inert": "^5.1.2",
104104
"@types/jasmine": "^2.8.6",
105105
"@types/node": "^9.4.6",
106-
"@types/vision": "^5.3.6",
107106
"camelcase": "^4.1.0",
108107
"domino": "^2.1.2",
109108
"express": "^4.15.2",

yarn.lock

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -561,14 +561,6 @@
561561
dependencies:
562562
"@types/node" "*"
563563

564-
"@types/vision@^5.3.6":
565-
version "5.3.6"
566-
resolved "https://registry.yarnpkg.com/@types/vision/-/vision-5.3.6.tgz#d696d007ca82254b955fd485bfae0f738d8ae617"
567-
integrity sha512-Wo+9LNI9wGcHRShuZW+lbwwj+g6+dyTxtHtNpzfYl4iehYzvFVzGyNo1MgW4qTHQCFEYOirLHBlrutkIRE2TMw==
568-
dependencies:
569-
"@types/hapi" "*"
570-
handlebars "^4.1.0"
571-
572564
"@types/z-schema@3.16.31":
573565
version "3.16.31"
574566
resolved "https://registry.yarnpkg.com/@types/z-schema/-/z-schema-3.16.31.tgz#2eb1d00a5e4ec3fa58c76afde12e182b66dc5c1c"
@@ -2630,17 +2622,6 @@ handlebars@^4.0.3:
26302622
optionalDependencies:
26312623
uglify-js "^3.1.4"
26322624

2633-
handlebars@^4.1.0:
2634-
version "4.2.0"
2635-
resolved "https://registry.yarnpkg.com/handlebars/-/handlebars-4.2.0.tgz#57ce8d2175b9bbb3d8b3cf3e4217b1aec8ddcb2e"
2636-
integrity sha512-Kb4xn5Qh1cxAKvQnzNWZ512DhABzyFNmsaJf3OAkWNa4NkaqWcNI8Tao8Tasi0/F4JD9oyG0YxuFyvyR57d+Gw==
2637-
dependencies:
2638-
neo-async "^2.6.0"
2639-
optimist "^0.6.1"
2640-
source-map "^0.6.1"
2641-
optionalDependencies:
2642-
uglify-js "^3.1.4"
2643-
26442625
hapi@^17.5.1:
26452626
version "17.8.1"
26462627
resolved "https://registry.yarnpkg.com/hapi/-/hapi-17.8.1.tgz#63cc5bbc138b6ae0919e977764647a17556e4c87"

0 commit comments

Comments
 (0)