Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: feat(common): introduce ls-routes #1002

Closed
wants to merge 3 commits into from
Closed

WIP: feat(common): introduce ls-routes #1002

wants to merge 3 commits into from

Conversation

Toxicable
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Feature

Continuation of #778

@Toxicable Toxicable changed the title WIPfeat(ls-routes): introduce ls-routes WIP: feat(ls-routes): introduce ls-routes May 20, 2018
@Toxicable Toxicable mentioned this pull request May 20, 2018
Closed
@Toxicable Toxicable changed the title WIP: feat(ls-routes): introduce ls-routes WIP: feat(common): introduce ls-routes May 20, 2018
@Toxicable
Copy link
Author

Blocked on not being able to test this due to

ReferenceError: HTTP_INTERCEPTORS is not defined

@swaechter swaechter mentioned this pull request May 28, 2018
Open
@Toxicable

This comment has been minimized.

Sign in to view
@CaerusKaru CaerusKaru added target: minor target: minor This PR is targeted for the next minor release area: common action: cleanup and removed state: blocked labels Jun 10, 2018
@CaerusKaru
Copy link
Member

Closing for now. If it's needed in the future we can bring it back.

@CaerusKaru CaerusKaru closed this Dec 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
@kyliau kyliau deleted the fabian/ls-routes branch March 28, 2020 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaerusKaru CaerusKaru Awaiting requested review from CaerusKaru

@vikerman vikerman Awaiting requested review from vikerman

Assignees
No one assigned
Labels
action: cleanup area: common state: WIP target: minor target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Toxicable @CaerusKaru @googlebot