Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(express-engine): add bundleDependencies and lazy-loading fixes #1167

Merged
merged 9 commits into from
May 26, 2019

Conversation

CaerusKaru
Copy link
Member

No description provided.

@vikerman
Copy link
Contributor

Fixes angular/angular-cli#12273 !!

@vikerman
Copy link
Contributor

Fixes angular/angular-cli#8616

@MarkPieszak
Copy link
Member

Wow !! I didn't know you guys were working on this - do you need me to look into anything / test it with some aspnet core apps? Amazing 👏

Copy link
Member

@MarkPieszak MarkPieszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💓

@vikerman
Copy link
Contributor

vikerman commented May 26, 2019

@MarkPieszak - We are essentially moving anything @angular or @nguniversal related to main.server.ts so that we don't end up with two copies of Angular.

How does this affect asp.net setup?

@vikerman vikerman merged commit d8be7af into master May 26, 2019
@CaerusKaru CaerusKaru deleted the adam/v8-scm branch May 26, 2019 18:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants