-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ng-aspnetcore-engine): adding initial new engine #682
feat(ng-aspnetcore-engine): adding initial new engine #682
Conversation
modules/aspnetcore-engine/index.ts
Outdated
|
||
return new Promise((resolve, reject) => { | ||
|
||
const platform = platformDynamicServer(providers); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please user platformServer only since platformDynamicServer would compile the whole app every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I need to do that and update the npm name as well.
…/universal into ng-aspnetcore-engine
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
WIP