Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Commit 1787339

Browse files
sjelinmhevery
authored andcommitted
fix(browser/utils): calling removeEventListener twice with the same args should not cause errors
Closes #283 Closes #284
1 parent 4a4d4f6 commit 1787339

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/browser/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ function zoneAwareRemoveEventListener(self: any, args: any[]) {
195195
// - When `addEventListener` is called on the global context in strict mode, `this` is undefined
196196
// see https://github.com/angular/zone.js/issues/190
197197
var target = self || _global;
198-
var eventTask = findExistingRegisteredTask(target, handler, eventName, useCapturing, false);
198+
var eventTask = findExistingRegisteredTask(target, handler, eventName, useCapturing, true);
199199
if (eventTask) {
200200
eventTask.zone.cancelTask(eventTask);
201201
} else {

test/browser/element.spec.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,13 @@ describe('element', function () {
257257
button.click();
258258
expect(log).toEqual('');
259259
});
260+
261+
it('should be able to deregister the same event twice', function() {
262+
var listener = (event) => {};
263+
document.body.addEventListener('click', listener, false);
264+
document.body.removeEventListener('click', listener, false);
265+
document.body.removeEventListener('click', listener, false);
266+
});
260267
});
261268

262269
});

0 commit comments

Comments
 (0)