Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

tlancina
Copy link
Contributor

On older versions of Chrome, patching via property descriptors isn't available, but unlike Safari, window.EventTarget exists and is already patched, so patching EventTarget methods on WebSocket.prototype again causes them to call the first patched method which then infinitely calls itself.

I didn't provide a test because the tests fail on any older Chrome version (not sure the exact range, tested on 39 and 41). I don't have access to SauceLabs, but I believe #192 will cause failure on at least the Android 4.4 case.

This is fairly high priority for Ionic as it seems to crash Android on some devices when using livereload.

On older versions of Chrome, patching via property descriptors isn't
available, but unlike Safari, window.EventTarget exists and is already
patched, so the EventTarget methods on WebSocket.prototype don't need to
be patched again.

Closes #233.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tlancina
Copy link
Contributor Author

I signed it ✏️

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@mhevery
Copy link
Contributor

mhevery commented Jan 27, 2016

@vicb Could you merge this and cut a new Zone release. This is blocking Ionic.

@btford btford closed this in 345e56c Jan 28, 2016
@tlancina
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants