This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(WebSocket): don't patch EventTarget methods twice #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older versions of Chrome, patching via property descriptors isn't available, but unlike Safari, window.EventTarget exists and is already patched, so patching EventTarget methods on WebSocket.prototype again causes them to call the first patched method which then infinitely calls itself.
I didn't provide a test because the tests fail on any older Chrome version (not sure the exact range, tested on 39 and 41). I don't have access to SauceLabs, but I believe #192 will cause failure on at least the Android 4.4 case.
This is fairly high priority for Ionic as it seems to crash Android on some devices when using livereload.