Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Keep WebSocket constants #267

Closed
wants to merge 1 commit into from

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Mar 1, 2016

WebSocket patch will brake WebSocket's constants

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mtsmfm
Copy link
Contributor Author

mtsmfm commented Mar 1, 2016

@google-admin I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@mtsmfm mtsmfm force-pushed the keep-websock-constants branch 4 times, most recently from 03c9fb1 to 0546593 Compare March 4, 2016 16:16
@mtsmfm mtsmfm force-pushed the keep-websock-constants branch from 0546593 to 49d79e8 Compare March 4, 2016 22:37
@mhevery mhevery closed this in f25b087 Mar 21, 2016
@mtsmfm mtsmfm deleted the keep-websock-constants branch March 21, 2016 23:31
@mtsmfm
Copy link
Contributor Author

mtsmfm commented Mar 21, 2016

😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants