Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

bug(Compiler): <ng-content select="..."> and CSS support #237

Closed
matanlurey opened this issue Dec 21, 2016 · 5 comments
Closed

bug(Compiler): <ng-content select="..."> and CSS support #237

matanlurey opened this issue Dec 21, 2016 · 5 comments
Assignees
@leonsenft

Comments

@matanlurey
Copy link
Contributor

Issue as described on stack overflow:

... this does not work:
<ng-content select="custom-action[type^='icon'][group='1']"></ng-content>

The current implementation doesn't support attribute selectors, which is unfortunate. @leonsenft is working on moving the compiler to use package:csslib instead of regular expressions, and we'll be fixing this use case.
@matanlurey
Copy link
Contributor Author

@leonsenft Any update?

@tonosama-atlacatl
Copy link

Hey guys, I know this might not be top priority, but any chances of seeing this fixed soon?
just wondering...

Thank you.

@leonsenft
Copy link
Contributor

Hi @tonosama-atlacatl, sorry this hasn't been prioritized yet. I'll try to get this fixed soon.

matanlurey pushed a commit that referenced this issue May 30, 2017
@leonsenft @matanlurey
Adds support for all attribute selectors
0898ea9 
Fixes #237.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157251667
@tonosama-atlacatl
Copy link

AWESOME!!, thank you guys!

@leonsenft
Copy link
Contributor

@tonosama-atlacatl No problem! Sorry for the wait.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leonsenft leonsenft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matanlurey @leonsenft @tonosama-atlacatl