Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on MSVC #112

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Fix build on MSVC #112

merged 1 commit into from
Mar 19, 2017

Conversation

accel2k
Copy link

@accel2k accel2k commented Mar 14, 2017

MSVC 2013 failed to build libepoxy due to error C2054: expected '(' to follow 'inline'.

@ebassi
Copy link
Collaborator

ebassi commented Mar 14, 2017

Hi! Thanks for your patch!

Would it be possible for you to leave a comment, either inside the build system or as a commit message, detailing the fix? Something simple, like what you wrote in the message of the PR would be perfect. This would avoid me doing dumb stuff six months down the line.

Thanks again!

The inline keyword is available only for C++ in MSVC.
So we need to use Microsoft specific __inline.
@accel2k
Copy link
Author

accel2k commented Mar 15, 2017

Hi!
I added comment as you asked.

@ebassi ebassi merged commit 3f932ae into anholt:master Mar 19, 2017
@ebassi
Copy link
Collaborator

ebassi commented Mar 19, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants