Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent future dates in TransactionForm #324

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Conversation

Anuj-Gill
Copy link
Contributor

Pull Request

Related Issues:
Issue number #323

Description:

  1. Addressed a bug that allowed users to select future dates in the TransactionForm, causing data inconsistencies.
  2. Implemented validation within the handleChange function to ensure only past or present dates are accepted.
  3. Added an error message to notify users when a future date is selected, guiding them to correct input.

Checklist:

  • I have tested my changes.
  • My code follows the project's coding standards.
  • I have updated the documentation (if applicable).

Screenshots:
When a future date is selected, the user get's this message!
image

Copy link

vercel bot commented Jan 3, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @ani1609 on Vercel.

@ani1609 first needs to authorize it.

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spendwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 7:43am

@ani1609
Copy link
Owner

ani1609 commented Jan 4, 2024

@Anuj-Gill the error message is getting displayed on setting the date from future. Please modify the code in a such a way that the error gets displayed only when the 'Add Transaction' or 'Edit Transaction' button is clicked

@Anuj-Gill
Copy link
Contributor Author

@ani1609 Updated the code. Please have a look when possible.

@ani1609
Copy link
Owner

ani1609 commented Jan 6, 2024

@Anuj-Gill done

@ani1609 ani1609 merged commit 2a1bb50 into ani1609:main Jan 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants