-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factorize: TransactionForm css #339
factorize: TransactionForm css #339
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @ani1609 on Vercel. @ani1609 first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@SharmaDhruv2511 you basically need to move all the css properties related to the html elements present inside Transaction.js file to the newly created Transaction.css file. You have copied them, but actually you need to move them cause there is no sense of writing same css properties multiple times. |
css that is written under the return statement, I have to move that css to Transactionform.css, right? @ani1609 |
@SharmaDhruv2511 Please try to understand, you just need to move the css properties for the elements present in TransactionForm.js from ExpenseTracer.css to the newly created TransactionForm.css file. |
@SharmaDhruv2511 currently, your PR seems like you have coped the code from ExpenseTracker.css to TransactionForm.css but after that you need to delete those from ExpenseTracker.css from that no longer be needed. |
Please review it @ani1609 |
@SharmaDhruv2511 good work |
Pull Request
Related Issues:
[List any related issues or reference them using the syntax
#issue_number
.]Fixes #(issue number)
#299
Description:
[Provide a brief description of your changes.]
As per the requirement I have successfully create a new file Transactionform css and add all the css code which is connected to Transactionform.js component.
Checklist:
Screenshots:
[If applicable, include screenshots to help reviewers understand your changes.]