Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorize: TransactionForm css #339

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

SharmaDhruv2511
Copy link
Contributor

@SharmaDhruv2511 SharmaDhruv2511 commented Jan 8, 2024

Pull Request

Related Issues:
[List any related issues or reference them using the syntax #issue_number.]

Fixes #(issue number)
#299
Description:
[Provide a brief description of your changes.]
As per the requirement I have successfully create a new file Transactionform css and add all the css code which is connected to Transactionform.js component.
Checklist:

  • I have tested my changes.
  • My code follows the project's coding standards.
  • I have updated the documentation (if applicable).

Screenshots:
[If applicable, include screenshots to help reviewers understand your changes.]

Copy link

vercel bot commented Jan 8, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @ani1609 on Vercel.

@ani1609 first needs to authorize it.

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spendwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 6:42pm

@ani1609
Copy link
Owner

ani1609 commented Jan 10, 2024

@SharmaDhruv2511 you basically need to move all the css properties related to the html elements present inside Transaction.js file to the newly created Transaction.css file. You have copied them, but actually you need to move them cause there is no sense of writing same css properties multiple times.

@SharmaDhruv2511
Copy link
Contributor Author

image

css that is written under the return statement, I have to move that css to Transactionform.css, right? @ani1609

@ani1609
Copy link
Owner

ani1609 commented Jan 11, 2024

@SharmaDhruv2511 Please try to understand, you just need to move the css properties for the elements present in TransactionForm.js from ExpenseTracer.css to the newly created TransactionForm.css file.

@ani1609
Copy link
Owner

ani1609 commented Jan 11, 2024

@SharmaDhruv2511 currently, your PR seems like you have coped the code from ExpenseTracker.css to TransactionForm.css but after that you need to delete those from ExpenseTracker.css from that no longer be needed.

@SharmaDhruv2511
Copy link
Contributor Author

Please review it @ani1609

@ani1609 ani1609 merged commit e4bac6d into ani1609:main Jan 11, 2024
2 of 3 checks passed
@ani1609
Copy link
Owner

ani1609 commented Jan 11, 2024

@SharmaDhruv2511 good work

@SharmaDhruv2511 SharmaDhruv2511 deleted the sharmadhruv/transactionform branch January 12, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants