Feat: Notification Support #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfiniteCoder06
changed the title
InfiniteCoder06
changed the title
|
@anilbeesetti This can now be Reviewers |
InfiniteCoder06
force-pushed
the
feature-notification
branch
from
3ec24e0
to
4717734
Compare
|
Glide will be replaced with Coil Once #689 Merges |
|
Any update? |
abhishek-za
reviewed
Mar 5, 2024
| @@ -136,11 +135,11 @@ class PlayerActivity : AppCompatActivity() { | |||
| /** | |||
| * Player | |||
| */ | |||
| private lateinit var controllerFuture: ListenableFuture<MediaController> | |||
| private val controller: MediaController? get() = if (controllerFuture.isDone) controllerFuture.get() else null | |||
There was a problem hiding this comment.
This will lead to crash. controllerFuture is not initialized yet.
|
I am currently busy with my exams will be looking into this project in mid-april |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Basic Notification Support, Custom Notication to be Implemented