-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cran checks #7
Comments
@faizan-khan-iit here is what the check for ggplot2Animint looks like on my system.
|
@tdhock I have made some relevant changes to the code. Could you please try again? The examples and tests still fail in the R CMD check though. As for this warning
I believe I already made those changes before (see here). Could you verify this on your system? Cause I am not getting this warning anymore.. My output for R CMD checks:
I guess some warnings might be because I am using a Windows machine. Still most errors are, as expected, in tests and examples... |
also you may want to turn on travis for this repo, with the standard r cran checks |
still have list() NULL problems
|
this line probably means you need to remove some library(ggplot2) from the testing code
|
need to change ggplot2 to ggplot2Animint in testthat.R! |
also in these files:
|
@tdhock I will try and replicate your output on my Linux system tomorrow if possible. Because I don't think we should still have that warning. Do you also get that warning while using the newer syntax in |
no warning for the animint2 code,
|
my Major Issue I am facing is on > install.packages("RSelenium")
Installing package into ‘C:/Users/Hp/Documents/R/win-library/3.5’
(as ‘lib’ is unspecified)
Warning in install.packages :
package ‘RSelenium’ is not available (for R version 3.5.0) Same for when done in R v3.4.4 Output: check()
Updating animint2 documentation
Loading animint2
Setting env vars --------------------------------------------------------
CFLAGS : -Wall -pedantic
CXXFLAGS: -Wall -pedantic
Building animint2 -------------------------------------------------------
"C:/PROGRA~1/R/R-35~1.0/bin/x64/R" --no-site-file --no-environ \
--no-save --no-restore --quiet CMD build \
"C:\Users\Hp\Desktop\GProject\animint2" --no-resave-data --no-manual
* checking for file 'C:\Users\Hp\Desktop\GProject\animint2/DESCRIPTION' ... OK
* preparing 'animint2':
* checking DESCRIPTION meta-information ... OK
* checking for LF line-endings in source and make files and shell scripts
* checking for empty or unneeded directories
* looking to see if a 'data/datalist' file should be added
* building 'animint2_2017.08.24.tar.gz'
Setting env vars --------------------------------------------------------
_R_CHECK_CRAN_INCOMING_ : FALSE
_R_CHECK_FORCE_SUGGESTS_: FALSE
Checking animint2 -------------------------------------------------------
"C:/PROGRA~1/R/R-35~1.0/bin/x64/R" --no-site-file --no-environ \
--no-save --no-restore --quiet CMD check \
"C:\Users\Hp\AppData\Local\Temp\RtmpGwKG83/animint2_2017.08.24.tar.gz" \
--as-cran --timings --no-manual
* using log directory 'C:/Users/Hp/AppData/Local/Temp/RtmpGwKG83/animint2.Rcheck'
* using R version 3.5.0 (2018-04-23)
* using platform: x86_64-w64-mingw32 (64-bit)
* using session charset: ISO8859-1
* using options '--no-manual --as-cran'
* checking for file 'animint2/DESCRIPTION' ... OK
* this is package 'animint2' version '2017.08.24'
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... NOTE
Package suggested but not available for checking: 'RSelenium'
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for .dll and .exe files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking serialization versions ... OK
* checking whether package 'animint2' can be installed ... OK
* checking package directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... WARNING
'::' or ':::' imports not declared from:
'RJSONIO' 'hexbin'
':::' call which should be '::': 'ggplot2Animint:::zeroGrob'
See the note in ?`:::` about the use of this operator.
Unexported objects imported by ':::' calls:
'ggplot2Animint:::guides_geom' 'ggplot2Animint:::guides_merge'
'ggplot2Animint:::guides_train' 'ggplot2Animint:::plot_theme'
'ggplot2Animint:::stairstep'
See the note in ?`:::` about the use of this operator.
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... NOTE
animint2dir: no visible global function definition for 'browseURL'
animint2gist: no visible global function definition for 'browseURL'
getCommonChunk: no visible global function definition for 'na.omit'
getLegendList: no visible global function definition for 'str'
html_dependency_animint: no visible global function definition for
'packageVersion'
html_dependency_plotJSON: no visible global function definition for
'packageVersion'
html_dependency_shinyAnimint: no visible global function definition for
'packageVersion'
parsePlot: no visible global function definition for 'setNames'
saveChunks: no visible global function definition for 'write.table'
saveChunks: no visible global function definition for 'str'
saveLayer : <anonymous>: no visible binding for global variable 'xminv'
saveLayer : <anonymous>: no visible binding for global variable 'y'
saveLayer : <anonymous>: no visible binding for global variable 'xmaxv'
saveLayer: no visible global function definition for 'head'
saveLayer: no visible global function definition for 'tail'
saveLayer: no visible global function definition for 'write.table'
saveLayer : bad.chunk: no visible binding for global variable
'chunks.for'
saveLayer: no visible global function definition for 'na.omit'
split.x: no visible global function definition for 'na.omit'
split.x: no visible global function definition for 'str'
stop_binary: no visible binding for global variable 'pJS'
stop_binary: no visible binding for global variable 'remDr'
tests_init: no visible binding for '<<-' assignment to 'pJS'
tests_init: no visible binding for '<<-' assignment to 'remDr'
tests_init: no visible binding for global variable 'remDr'
toRGB: no visible global function definition for 'col2rgb'
toRGB: no visible global function definition for 'rgb'
Undefined global functions or variables:
browseURL chunks.for col2rgb head na.omit pJS packageVersion remDr
rgb setNames str tail write.table xmaxv xminv y
Consider adding
importFrom("grDevices", "col2rgb", "rgb")
importFrom("stats", "na.omit", "setNames")
importFrom("utils", "browseURL", "head", "packageVersion", "str",
"tail", "write.table")
to your NAMESPACE file.
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
* checking Rd cross-references ... WARNING
Missing link or links in documentation object 'animint2dir.Rd':
'ggplot2'
See section 'Cross-references' in the 'Writing R Extensions' manual.
* checking for missing documentation entries ... WARNING
Undocumented code objects:
'ChromHMMiterations' 'FluView' 'FunctionalPruning' 'PeakConsistency'
'TestROC' 'UStornadoes' 'VariantModels' 'WorldBank' 'breakpoints'
'change' 'climate' 'compare' 'generation.loci' 'intreg' 'malaria'
'mixtureKNN' 'pirates' 'prior' 'prostateLasso' 'vervet' 'worldPop'
Undocumented data sets:
'ChromHMMiterations' 'FluView' 'FunctionalPruning' 'PeakConsistency'
'TestROC' 'UStornadoes' 'VariantModels' 'WorldBank' 'breakpoints'
'change' 'climate' 'compare' 'generation.loci' 'intreg' 'malaria'
'mixtureKNN' 'pirates' 'prior' 'prostateLasso' 'vervet' 'worldPop'
All user-level objects in a package should have documentation entries.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... WARNING
Undocumented arguments in documentation object 'geom_tallrect'
'na.rm' 'show.legend' 'inherit.aes'
Undocumented arguments in documentation object 'geom_widerect'
'na.rm' 'show.legend' 'inherit.aes'
Undocumented arguments in documentation object 'getCommonChunk'
'chunk.vars'
Undocumented arguments in documentation object 'parsePlot'
'plot' 'plot.name'
Undocumented arguments in documentation object 'saveLayer'
'layer_name' 'ggplot' 'built' 'AnimationInfo'
Documented arguments not in \usage in documentation object 'saveLayer':
'geom_num'
Undocumented arguments in documentation object 'setPlotSizes'
'AllPlotsInfo'
Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking contents of 'data' directory ... OK
* checking data for non-ASCII characters ... OK
* checking data for ASCII and uncompressed saves ... OK
* checking examples ... ERROR
Running examples in 'animint2-Ex.R' failed
The error most likely occurred in:
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: animint2dir
> ### Title: Compile and render an animint in a local directory
> ### Aliases: animint2dir animint
>
> ### ** Examples
>
> ## Make a Gapminder plot (aka Google motion chart), which is actually
> ## just a scatterplot with size and color that moves over time.
> library(animint2)
> data(WorldBank)
> gapminder <-
+ list(title="Linked scatterplot and time series",
+ ts=ggplot()+
+ make_tallrect(WorldBank, "year")+
+ geom_line(aes(year, life.expectancy, group=country, color=region),
+ clickSelects="country",
+ data=WorldBank, size=4, alpha=3/5),
+ time=list(variable="year",ms=3000),
+ duration=list(year=1000),
+ scatter=ggplot()+
+ geom_point(aes(fertility.rate, life.expectancy,
+ key=country, colour=region, size=population),
+ showSelected="year",
+ clickSelects="country",
+ data=WorldBank)+
+ geom_text(aes(fertility.rate, life.expectancy, label=country),
+ showSelected=c("country", "year"),
+ data=WorldBank)+
+ make_text(WorldBank, 5, 80, "year")+
+ scale_size_animint(pixel.range=c(2,20), breaks=10^(4:9)))
> animint2dir(gapminder, "WorldBank-viz")
Warning in issueSelectorWarnings(meta$geoms, meta$selector.aes, meta$duration) :
to ensure that smooth transitions are interpretable, aes(key) should be specifed for geoms with showSelected=year, problem: geom4_text_scatter
Warning in issueSelectorWarnings(meta$geoms, meta$selector.aes, meta$duration) :
to ensure that smooth transitions are interpretable, aes(key) should be specifed for geoms with showSelected=year, problem: geom5_text_scatter
Error in loadNamespace(name) : there is no package called 'RJSONIO'
Calls: animint2dir ... tryCatch -> tryCatchList -> tryCatchOne -> <Anonymous>
Execution halted
* checking for unstated dependencies in 'tests' ... OK
* checking tests ...
Running 'testthat.R'
ERROR
Running the tests in 'tests/testthat.R' failed.
Complete output:
> library("testthat")
> library("animint2")
Loading required package: ggplot2Animint
> library("RSelenium")
Error in library("RSelenium") : there is no package called 'RSelenium'
Execution halted
* DONE
Status: 2 ERRORs, 4 WARNINGs, 2 NOTEs
See
'C:/Users/Hp/AppData/Local/Temp/RtmpGwKG83/animint2.Rcheck/00check.log'
for details.
R CMD check results
2 errors | 4 warnings | 2 notes
checking examples ... ERROR
Running examples in 'animint2-Ex.R' failed
The error most likely occurred in:
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: animint2dir
> ### Title: Compile and render an animint in a local directory
> ### Aliases: animint2dir animint
>
> ### ** Examples
... 23 lines ...
+ data=WorldBank)+
+ make_text(WorldBank, 5, 80, "year")+
+ scale_size_animint(pixel.range=c(2,20), breaks=10^(4:9)))
> animint2dir(gapminder, "WorldBank-viz")
Warning in issueSelectorWarnings(meta$geoms, meta$selector.aes, meta$duration) :
to ensure that smooth transitions are interpretable, aes(key) should be specifed for geoms with showSelected=year, problem: geom4_text_scatter
Warning in issueSelectorWarnings(meta$geoms, meta$selector.aes, meta$duration) :
to ensure that smooth transitions are interpretable, aes(key) should be specifed for geoms with showSelected=year, problem: geom5_text_scatter
Error in loadNamespace(name) : there is no package called 'RJSONIO'
Calls: animint2dir ... tryCatch -> tryCatchList -> tryCatchOne -> <Anonymous>
Execution halted
checking tests ... ERROR
Running 'testthat.R'
Running the tests in 'tests/testthat.R' failed.
Complete output:
> library("testthat")
> library("animint2")
Loading required package: ggplot2Animint
> library("RSelenium")
Error in library("RSelenium") : there is no package called 'RSelenium'
Execution halted
checking dependencies in R code ... WARNING
'::' or ':::' imports not declared from:
'RJSONIO' 'hexbin'
':::' call which should be '::': 'ggplot2Animint:::zeroGrob'
See the note in ?`:::` about the use of this operator.
Unexported objects imported by ':::' calls:
'ggplot2Animint:::guides_geom' 'ggplot2Animint:::guides_merge'
'ggplot2Animint:::guides_train' 'ggplot2Animint:::plot_theme'
'ggplot2Animint:::stairstep'
See the note in ?`:::` about the use of this operator.
checking Rd cross-references ... WARNING
Missing link or links in documentation object 'animint2dir.Rd':
'ggplot2'
See section 'Cross-references' in the 'Writing R Extensions' manual.
checking for missing documentation entries ... WARNING
Undocumented code objects:
'ChromHMMiterations' 'FluView' 'FunctionalPruning' 'PeakConsistency'
'TestROC' 'UStornadoes' 'VariantModels' 'WorldBank' 'breakpoints'
'change' 'climate' 'compare' 'generation.loci' 'intreg' 'malaria'
'mixtureKNN' 'pirates' 'prior' 'prostateLasso' 'vervet' 'worldPop'
Undocumented data sets:
'ChromHMMiterations' 'FluView' 'FunctionalPruning' 'PeakConsistency'
'TestROC' 'UStornadoes' 'VariantModels' 'WorldBank' 'breakpoints'
'change' 'climate' 'compare' 'generation.loci' 'intreg' 'malaria'
'mixtureKNN' 'pirates' 'prior' 'prostateLasso' 'vervet' 'worldPop'
All user-level objects in a package should have documentation entries.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.
checking Rd \usage sections ... WARNING
Undocumented arguments in documentation object 'geom_tallrect'
'na.rm' 'show.legend' 'inherit.aes'
Undocumented arguments in documentation object 'geom_widerect'
'na.rm' 'show.legend' 'inherit.aes'
Undocumented arguments in documentation object 'getCommonChunk'
'chunk.vars'
... 6 lines ...
Documented arguments not in \usage in documentation object 'saveLayer':
'geom_num'
Undocumented arguments in documentation object 'setPlotSizes'
'AllPlotsInfo'
Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.
checking package dependencies ... NOTE
Package suggested but not available for checking: 'RSelenium'
checking R code for possible problems ... NOTE
animint2dir: no visible global function definition for 'browseURL'
animint2gist: no visible global function definition for 'browseURL'
getCommonChunk: no visible global function definition for 'na.omit'
getLegendList: no visible global function definition for 'str'
html_dependency_animint: no visible global function definition for
'packageVersion'
html_dependency_plotJSON: no visible global function definition for
'packageVersion'
html_dependency_shinyAnimint: no visible global function definition for
... 21 lines ...
toRGB: no visible global function definition for 'col2rgb'
toRGB: no visible global function definition for 'rgb'
Undefined global functions or variables:
browseURL chunks.for col2rgb head na.omit pJS packageVersion remDr
rgb setNames str tail write.table xmaxv xminv y
Consider adding
importFrom("grDevices", "col2rgb", "rgb")
importFrom("stats", "na.omit", "setNames")
importFrom("utils", "browseURL", "head", "packageVersion", "str",
"tail", "write.table")
to your NAMESPACE file. |
this issue will be to discuss how to fix issues in R CMD check --as-cran
The text was updated successfully, but these errors were encountered: