-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ggplot2Animint dependency #23
Conversation
…o avoid error from collate
Merge ggplot2Animint into animint2
renaming function names to a_*
merge code of animint2
@faizan-khan-iit Summary of changes made here:
|
looks good in general, glad to see all tests are passing in this branch ggplot2/ggplot2Animint is no longer required, right? however on the README under Installation it still says to install ggplot2 -- can you please remove that line from the README? and maybe add a sentence or two that explains that ggplot2 functions have been forked and are included |
@tdhock removed the line, but I don't know why Travis is failing now. seems like error from Travis side. |
hi @vivekktiwari sorry it has taken me so long to look into this. there was some problem with the test definition -- I had to add scale_y(breaks=something) in order to get the right number of grid lines to show up in the data viz -- they are now passing on my machine. I also bumped the version and it looks like this is ready to merge with master right? (I am a bit confused about all of the other PRs you opened -- I assume this is the most relevant one -- please close the ones that are no longer relevant) |
Hi vivek I pushed a new TEST_SUITE=CRAN which runs the CRAN checks.
hopefully we can get that working before merging with master.
…On Thu, Oct 4, 2018 at 12:04 PM Vivek Kumar ***@***.***> wrote:
hi @tdhock <https://github.com/tdhock>, sorry I have been inactive, all
due to extra coursework, exams and placement,
Yes! This is the most relevant one. #25
<#25> is work-in-progress, I will
resume working in a month, I will soon close irrelevant PRs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA478uTx1H5uz4SUd1tMvpjtD-8UFyJVks5uhlu2gaJpZM4UpEha>
.
|
Is it feasible to separate the TEST_SUIT=CRAN from other test suits, as we won't be running major of the other test cases while submitting to CRAN, right? |
right, for CRAN I execute
https://github.com/tdhock/animint2/blob/merge/build.sh which only runs the
compiler tests
…On Fri, Oct 5, 2018 at 10:10 AM Vivek Kumar ***@***.***> wrote:
Is it feasible to separate the TEST_SUIT=CRAN from other test suits, as we
won't be running major of the other test cases while submitting to CRAN,
right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA478iONH1GxJfbVZPvwtd7U1M_hHvFTks5uh5KCgaJpZM4UpEha>
.
|
hey @vivekktiwari tests are now passing can you please review the code and tell me if you think we should merge with master as it is right now, or do you think we need to add something else? |
@tdhock according to me, I think it is ready to merge. |
README.org
Outdated
@@ -18,6 +18,9 @@ new syntax. | |||
|
|||
** Differences with old animint | |||
|
|||
|
|||
06-10-2018: =train_layout= [from ggplot2 - R/panel.R] function is now =g_train_layout=. =train_layout= [from animint2- R/z_facet.R] function is the same. Both are =internal functions=. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @vivekktiwari I moved this to NEWS since README should only contain info which is important for users (not info about internal functions)
merged! thanks so much for all your hard work @vivekktiwari |
@tdhock test suite is passing.
sorry for extra PRs had to move all codes to
merge
branch