Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import ggplot2Animint from cran branch #24

Closed
wants to merge 8 commits into from
Closed

Conversation

vivekktiwari
Copy link
Contributor

This PR is to test the changes made in ggplot2Animint with animint2, whether it supports changes or not.

@vivekktiwari
Copy link
Contributor Author

@faizan-khan-iit @tdhock so I am testing the changes made by me in faizan-khan-iit/ggplot2@cran whether it will run properly or not, but I am getting few errors.
I have renamed all the syntax changes like ggplot to a_plot and all class function here
Can you help me with this one please:

checking examples ... ERROR
Running examples in 'animint2-Ex.R' failed
The error most likely occurred in:

> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: animint2dir
> ### Title: Compile and render an animint in a local directory
> ### Aliases: animint2dir animint
> 
> ### ** Examples
... 20 lines ...
+                   data=WorldBank)+
+        geom_text(aes(fertility.rate, life.expectancy, label=country),
+                  showSelected=c("country", "year"),
+                  data=WorldBank)+
+        make_text(WorldBank, 5, 80, "year")+
+        scale_size_animint(pixel.range=c(2,20), breaks=10^(4:9)))
> animint2dir(gapminder, "WorldBank-viz")
Error in `$<-.data.frame`(`*tmp*`, "group", value = 0L) : 
  replacement has 1 row, data has 0
Calls: animint2dir -> saveLayer -> $<- -> $<-.data.frame
Execution halted

@vivekktiwari
Copy link
Contributor Author

vivekktiwari commented Jun 24, 2018

I checked gapminder and it is not taking any data, I don't know why, maybe that is the cause of error, but couldn't find the reason.
update:

> gapminder$ts$data
list()
attr(,"class")
[1] "waiver"
> gapminder$ts

this is working fine.

@vivekktiwari
Copy link
Contributor Author

Issue Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants