fetch entity statement chains #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
berendsliedrecht
commented
Jul 12, 2024
•
berendsliedrecht
commented
- feat: fetch entity statement chain
berendsliedrecht
force-pushed
the
fetch-entity-statement-chains
branch
from
c80e1e9
to
af980ea
Compare
TimoGlastra
approved these changes
Jul 12, 2024
| entityConfigurations, | ||
| }: FetchEntityStatementChainOptions) => { | ||
| // The trust anchors (i.e. the last item of the list) entity configuration will be used instead of a statement issued by a superior | ||
| const statements = [entityConfigurations[entityConfigurations.length - 1]] |
There was a problem hiding this comment.
Do we check/ensure tbis array is non empty?
I think enabling noUncheckedIndexAccess or whatever it is called in TS compilerOptioms might be good
There was a problem hiding this comment.
Added it which did not help here (but some other places it did) so I just added a check manually that it is non-empty.
Comment on lines
55
to
62
| const results = await Promise.allSettled(promises) | ||
| for (const res of results) { | ||
| if (res.status === 'fulfilled') { | ||
| statements.push(res.value) | ||
| } else { | ||
| throw new OpenIdFederationError(ErrorCode.Validation, res.reason) | ||
| } | ||
| } |
There was a problem hiding this comment.
If it fails when one fails, we can just use Promise.all right?
Would be good to pass an abort signal to the fetch methods so you can cancel all promises instantly when one fails.
There was a problem hiding this comment.
Created a ticket for the abort signal. Optimalization for later I'd say.
berendsliedrecht
force-pushed
the
fetch-entity-statement-chains
branch
from
af980ea
to
69b2d45
Compare
Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
berendsliedrecht
force-pushed
the
fetch-entity-statement-chains
branch
from
69b2d45
to
77b3e3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.