Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New structure #19

Merged
merged 39 commits into from
Apr 11, 2022
Merged

New structure #19

merged 39 commits into from
Apr 11, 2022

Conversation

berendsliedrecht
Copy link
Member

Lots and lots of changes. Quick summary:

  1. Updated the registration using the NativeModules method. This will fix a minor bug on iOS and makes it possisble to use autolinking on both iOS and Android.
  2. Renamed variables and filenames to camelcase.
  3. Removed unused functionality

@berendsliedrecht
android works and can sign
11b9070 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
ios works and all the functions work
0aedb37 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
ios works in other project
ce0d5bb 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
using correct cpp-adapter
089b11e 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
cpp tests work
af8092c 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
added gaurd that input MUST be object
3e9df45 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
refactored registering of functions
78dd25e 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
added 80046typeof function
0723cb4 
Signed-off-by: Berend Sliedrecht <berend@animo.id>
@berendsliedrecht
added comment about 4045typeof
7d98ebb 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
fixed some imports and removed CONTRIBUTING.md
af3774a 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
fix: removed REACT NATIVE version as cpp flag
5fd7bb3 
Signed-off-by: blu3beri <berend@animo.id>
TimoGlastra
TimoGlastra approved these changes Apr 11, 2022
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/bbsSignature.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@berendsliedrecht
added docs and improved tests
ad687f2 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: added cpp test
0487d2d 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
style: run prettier
eeb173d 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: fixed cmake path voor .so
988e372 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: added -pthread flag to CMAKE
8bf1dac 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
test: added static c++ and glibc
6572f45 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: use -pthread at link time
881a484 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: added pthread as lib
2f227f4 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: use cmake thread lib
96fefef 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: seperated validation and tests
fc0b58a 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: fixed syntax issues
dde6659 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: single step tests
cf84bfb 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: cd into cpp/tests...
f8656fa 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
added get cmake build step
42a639e 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: added buildstep for the library
9540862 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: fetch the correct library
91ef28c 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: run ls _R
ccecebc 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build: checkout only
befbe39 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
825c33a 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
8b10728 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
0ccea73 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
380560f 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
10a94ca 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
2166960 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
87cea77 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
db99ee4 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
e5ba650 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht
build
f18e5b3 
Signed-off-by: blu3beri <berend@animo.id>
@berendsliedrecht berendsliedrecht merged commit fb67b58 into main Apr 11, 2022
@berendsliedrecht berendsliedrecht deleted the new-structure branch April 11, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berendsliedrecht @TimoGlastra