feat: upload image to aws s3 #200

CleverFool77 · 2019-02-21T12:20:19Z

Description

Save User images on Amazon S3
Save object URL of image in aws s3 on UserModel photo_url field
Return photo_url on new api endpoint user/profile_picture

Fixes #152

Server will be getting an encoded string of image as input,The image will be decoded and uploaded on aws s3. Then aws s3 url of the image will be saved in the db field of user's photo_url. A new api endpoint to return the user's profile picture is created.
The testing has been done in my own aws s3 bucket. Three environment variables AWS_ACCESS_KEY_ID , AWS_SECRET_ACCESS_KEY and AWS_PROFILE_BUCKET are created. The username is taken as image name to avoid multiple images of user.
I've extracted the image extension from the encoded string input (uploaded from frontend).

It's assumed that the frontend encodes the image in base64 encoding.

Type of Change:

Delete irrelevant options.

Code
Quality Assurance
User Interface
Outreach
Documentation

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

This has been tested using postman.

Checklist:

Delete irrelevant options.

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
Any dependent changes have been merged
Update Postman API at /docs folder
Update Swagger documentation and the exported file at /docs folder
Update requirements.txt

Code/Quality Assurance Only

My changes generate no new warnings
My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been published in downstream modules

sys-bot · 2019-02-21T12:20:20Z

Please send PRs only to approved issues.

CleverFool77 · 2019-02-21T12:21:38Z

@isabelcosta @ramitsawhney27 I've opened a Pr reagrding the upload of image in amazon s3 for the issue #152

app/api/dao/user.py

CleverFool77 · 2019-03-03T08:11:34Z

@ramitsawhney27 @agarwalrounak I've updated the PR.

app/api/dao/user.py

CleverFool77 · 2019-03-04T16:59:27Z

@ramitsawhney27 I've updated the PR with the changes and removed the merge conflict.

isabelcosta · 2019-03-05T20:49:59Z

@CleverFool77 uploading an image is testable on Postman? I have to try this. Thank you so much for the work you're doing here.

CleverFool77 · 2019-03-06T02:36:30Z

@isabelcosta Yes we can test it on Postman.

In the code, we have to setup the environment variable which include the name of bucket and other aws details.
As the input image in encoded string , so in update user profile endpoint. we put the encoded string in base64 of image as input.
The further process will be according to code - Uploading decoded image to aws s3, storing the image url from aws s3 to database.
The link of user's profile image url in amazon aws s3 is returned in Profile picture endpoint.

isabelcosta

@CleverFool77 I left two comments. I haven't got the time to test this feature yet. Once I do, I'll give you a complete review

app/api/dao/user.py

isabelcosta · 2019-03-18T22:29:07Z

@m-murad we have to setup these (e.g.: AWS_ACCESS_KEY and etc) on TravisCI right?
We need @mayburgos help with the credentials as well.

isabelcosta

@CleverFool77 I'm ok with this after you make the changes I requested ;)

CleverFool77 · 2019-03-20T10:08:45Z

Hi @isabelcosta I've updated the PR as requested.
Thanks :)

isabelcosta

@CleverFool77 left a comment for a typo. It's almost done ;)

isabelcosta · 2019-03-26T21:32:24Z

app/api/dao/user.py

+            if 'photo_url' in data and data['photo_url']:
+                image_type = data['photo_url'].split(';')[0].split('/')[1]
+                image_name = ".".join((username, image_type))
+                photo_url = aws_upload.upload_to_aws(data['photo_url'], application.congif["AWS_PROFILE_BUCKET"], image_name)


Suggested change

photo_url = aws_upload.upload_to_aws(data['photo_url'], application.congif["AWS_PROFILE_BUCKET"], image_name)

photo_url = aws_upload.upload_to_aws(data['photo_url'], application.config["AWS_PROFILE_BUCKET"], image_name)

@CleverFool77 this doesn't appear to be changed. Maybe it happened something when you squashed the commits. Can you please change that.

Suggested change

photo_url = aws_upload.upload_to_aws(data['photo_url'], application.congif["AWS_PROFILE_BUCKET"], image_name)

photo_url = aws_upload.upload_to_aws(data['photo_url'], application.config["AWS_PROFILE_BUCKET"], image_name)

config.py

CleverFool77 · 2019-04-13T08:06:04Z

Hi @isabelcosta
I missed out the mention.
I've updated the PR.
Thanks for the patience !!

isabelcosta · 2019-05-12T00:34:02Z

@CleverFool77 thank you so much for your contribution and patience! Well done! 🎉

I'm not sure when I will merge this because I haven't figure out yet if it's better to set up the environments to the AWS Systers uses, or not. I'm also analyzing the volatile database issue and where data will be stored, and all of this thinking about the development environment. Your work here is done, just wanted to let you know where I'm at.

There's also the possibility of merging this without the environment variables set, and all run ok. I have to test this, yet. Once I do, if all goes well I can merge right away.

cc @ramitsawhney27

isabelcosta

@CleverFool77 left some comments because of something I noticed on the Travis CI current configuration.
Let me know if you need any clarification.

isabelcosta · 2019-08-22T18:24:47Z

config.py

@@ -14,6 +14,11 @@ class BaseConfig(object):
    JWT_ACCESS_TOKEN_EXPIRES = timedelta(weeks=1)
    JWT_REFRESH_TOKEN_EXPIRES = timedelta(weeks=4)

+    # Aws details
+    AWS_ACCESS_KEY_ID = os.getenv('AWS_ACCESS_KEY_ID')


Suggested change

AWS_ACCESS_KEY_ID = os.getenv('AWS_ACCESS_KEY_ID')

AWS_ACCESS_KEY_ID = os.getenv('AWS_ACCESS_ID')

Can you please change the expected environment variable to AWS_ACCESS_ID. I'm saying this because during the Community Open Session with @mayburgos and @m-murad that Travis CI has that variable like AWS_ACCESS_ID instead of AWS_ACCESS_KEY_ID.

isabelcosta · 2019-08-22T18:26:50Z

app/api/dao/user.py

+            if 'photo_url' in data and data['photo_url']:
+                image_type = data['photo_url'].split(';')[0].split('/')[1]
+                image_name = ".".join((username, image_type))
+                photo_url = aws_upload.upload_to_aws(data['photo_url'], application.congif["AWS_PROFILE_BUCKET"], image_name)


@CleverFool77 this doesn't appear to be changed. Maybe it happened something when you squashed the commits. Can you please change that.

Suggested change

photo_url = aws_upload.upload_to_aws(data['photo_url'], application.congif["AWS_PROFILE_BUCKET"], image_name)

photo_url = aws_upload.upload_to_aws(data['photo_url'], application.config["AWS_PROFILE_BUCKET"], image_name)

CleverFool77 · 2019-08-28T05:43:24Z

Thanks @isabelcosta for the review.
I'll update the PR soon.

Fixes anitab-org#152

CleverFool77 · 2019-09-22T06:02:54Z

Hii @isabelcosta !!
I have updated the PR as requested.

Thanks !!!

vj-codes · 2020-10-07T16:01:36Z

@CleverFool77 hey can you please solve the merge conflicts ? Thanks!

vj-codes · 2021-02-20T18:52:31Z

@CleverFool77 closing the PR due to inactivity , thank you for your contribution :)

isabelcosta · 2021-02-21T20:23:45Z

@vj-codes thank you for closing this. At the moment we don't have access to AWS S3 so this wouldn't be merged so soon. We'll reopen if the situation changes.
Thank you for your contribution @CleverFool77 , I hope you learned something new with this PR, I sure did :)

sys-bot added the Not Reviewed label Feb 21, 2019

sys-bot closed this Feb 21, 2019

isabelcosta reopened this Feb 21, 2019

CleverFool77 force-pushed the aws_s3_upload branch from 2e4af22 to d812dbd Compare February 22, 2019 02:51

agarwalrounak reviewed Feb 23, 2019

View reviewed changes

app/api/dao/user.py Show resolved Hide resolved

ramitsawhney27 suggested changes Feb 23, 2019

View reviewed changes

app/api/dao/user.py Outdated Show resolved Hide resolved

app/api/dao/user.py Outdated Show resolved Hide resolved

ramitsawhney27 reviewed Feb 23, 2019

View reviewed changes

app/api/dao/user.py Outdated Show resolved Hide resolved

CleverFool77 force-pushed the aws_s3_upload branch 2 times, most recently from e1ac1b6 to ca69d2d Compare March 3, 2019 08:11

CleverFool77 force-pushed the aws_s3_upload branch from ca69d2d to 704f8fa Compare March 3, 2019 08:13

ramitsawhney27 suggested changes Mar 3, 2019

View reviewed changes

app/api/dao/user.py Outdated Show resolved Hide resolved

CleverFool77 force-pushed the aws_s3_upload branch 2 times, most recently from b9811f8 to 707e87a Compare March 4, 2019 16:58

isabelcosta removed the Not Reviewed label Mar 5, 2019

ramitsawhney27 previously approved these changes Mar 11, 2019

View reviewed changes

isabelcosta reviewed Mar 14, 2019

View reviewed changes

app/api/dao/user.py Outdated Show resolved Hide resolved

app/api/dao/user.py Outdated Show resolved Hide resolved

isabelcosta requested changes Mar 18, 2019

View reviewed changes

CleverFool77 dismissed ramitsawhney27’s stale review via 65334a2 March 20, 2019 10:07

CleverFool77 force-pushed the aws_s3_upload branch from 707e87a to 65334a2 Compare March 20, 2019 10:07

ramitsawhney27 previously approved these changes Mar 21, 2019

View reviewed changes

isabelcosta requested changes Mar 26, 2019

View reviewed changes

CleverFool77 dismissed ramitsawhney27’s stale review via c746346 April 13, 2019 08:04

CleverFool77 force-pushed the aws_s3_upload branch from 65334a2 to c746346 Compare April 13, 2019 08:04

ramitsawhney27 previously approved these changes Apr 14, 2019

View reviewed changes

isabelcosta approved these changes May 12, 2019

View reviewed changes

isabelcosta requested changes Aug 22, 2019

View reviewed changes

feat: upload image to aws s3

bf20acd

Fixes anitab-org#152

CleverFool77 dismissed ramitsawhney27’s stale review via bf20acd September 22, 2019 06:01

CleverFool77 force-pushed the aws_s3_upload branch from c746346 to bf20acd Compare September 22, 2019 06:01

isabelcosta mentioned this pull request May 27, 2020

Send/Receive photos on Backend anitab-org/mentorship-android#24

Open

4 tasks

vj-codes closed this Feb 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upload image to aws s3 #200

feat: upload image to aws s3 #200

CleverFool77 commented Feb 21, 2019

sys-bot commented Feb 21, 2019

CleverFool77 commented Feb 21, 2019

CleverFool77 commented Mar 3, 2019

CleverFool77 commented Mar 4, 2019

isabelcosta commented Mar 5, 2019

CleverFool77 commented Mar 6, 2019 •

edited

Loading

isabelcosta left a comment

isabelcosta commented Mar 18, 2019

isabelcosta left a comment

CleverFool77 commented Mar 20, 2019

isabelcosta left a comment

isabelcosta Mar 26, 2019

CleverFool77 Apr 14, 2019

isabelcosta Aug 22, 2019

CleverFool77 commented Apr 13, 2019

isabelcosta commented May 12, 2019

isabelcosta left a comment

isabelcosta Aug 22, 2019

isabelcosta Aug 22, 2019

CleverFool77 commented Aug 28, 2019

CleverFool77 commented Sep 22, 2019

vj-codes commented Oct 7, 2020

vj-codes commented Feb 20, 2021

isabelcosta commented Feb 21, 2021

	photo_url = aws_upload.upload_to_aws(data['photo_url'], application.congif["AWS_PROFILE_BUCKET"], image_name)
	photo_url = aws_upload.upload_to_aws(data['photo_url'], application.config["AWS_PROFILE_BUCKET"], image_name)

	AWS_ACCESS_KEY_ID = os.getenv('AWS_ACCESS_KEY_ID')
	AWS_ACCESS_KEY_ID = os.getenv('AWS_ACCESS_ID')

feat: upload image to aws s3 #200

feat: upload image to aws s3 #200

Conversation

CleverFool77 commented Feb 21, 2019

Description

Type of Change:

How Has This Been Tested?

Checklist:

sys-bot commented Feb 21, 2019

CleverFool77 commented Feb 21, 2019

CleverFool77 commented Mar 3, 2019

CleverFool77 commented Mar 4, 2019

isabelcosta commented Mar 5, 2019

CleverFool77 commented Mar 6, 2019 • edited Loading

isabelcosta left a comment

Choose a reason for hiding this comment

isabelcosta commented Mar 18, 2019

isabelcosta left a comment

Choose a reason for hiding this comment

CleverFool77 commented Mar 20, 2019

isabelcosta left a comment

Choose a reason for hiding this comment

isabelcosta Mar 26, 2019

Choose a reason for hiding this comment

CleverFool77 Apr 14, 2019

Choose a reason for hiding this comment

isabelcosta Aug 22, 2019

Choose a reason for hiding this comment

CleverFool77 commented Apr 13, 2019

isabelcosta commented May 12, 2019

isabelcosta left a comment

Choose a reason for hiding this comment

isabelcosta Aug 22, 2019

Choose a reason for hiding this comment

isabelcosta Aug 22, 2019

Choose a reason for hiding this comment

CleverFool77 commented Aug 28, 2019

CleverFool77 commented Sep 22, 2019

vj-codes commented Oct 7, 2020

vj-codes commented Feb 20, 2021

isabelcosta commented Feb 21, 2021

CleverFool77 commented Mar 6, 2019 •

edited

Loading