Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

add python-decouple for handling the environment variables #580

Closed
5 tasks
theyashshahs opened this issue Jul 10, 2020 · 6 comments · Fixed by #592
Closed
5 tasks

add python-decouple for handling the environment variables #580

theyashshahs opened this issue Jul 10, 2020 · 6 comments · Fixed by #592
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@theyashshahs
Copy link
Contributor

theyashshahs commented Jul 10, 2020

Description

As a member,
I need to add python-decouple to manage the DJANGO SECRET KEY and other sensitive env variables,
so that I can easily set up the project.

Acceptance Criteria

Update [Required]

  • settings/base.py
  • settings/dev.py
  • requirements/prod.txt

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1 hour

@sakshi1499 sakshi1499 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 10, 2020
@saideepesh000
Copy link
Contributor

@sakshi1499 Can I try this.

@theyashshahs
Copy link
Contributor Author

@saideepesh000 go for it 👍

@theyashshahs theyashshahs added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Jul 13, 2020
@saideepesh000
Copy link
Contributor

@yashshah2820 @sakshi1499, For now, what should I keep in the .env file

@theyashshahs
Copy link
Contributor Author

@saideepesh000 you can use the env variables used in the README like SECRET_KEY='foobarbaz' and the env variables in base.py and dev.py 😃

@saideepesh000
Copy link
Contributor

saideepesh000 commented Jul 14, 2020

@yashshah2820 Ok, what should I keep the database password in env. And a small doubt, why are we not updating production.py with python-decouple, because that's going to be on the hosted part.

@theyashshahs
Copy link
Contributor Author

@saideepesh000 it's all in the README

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants