Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Added Maps and Tests for SearchView #562

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

ritwickraj78
Copy link
Contributor

Description

  • Added Map
  • Styling for the Map as suggested
  • Adding Markers
  • Marker animation according to search
  • Info Window with the link

Fixes #536

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

  • Tests have been added
  • All local tests pass
  • CI check passes

gsoc3

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LaibaBasit008 LaibaBasit008 added the Status: Needs Review PR needs an additional review or a maintainer's review. label Jun 11, 2020
@ritwickraj78
Copy link
Contributor Author

@SanketDG @sakshi1499 @sammy1997 I have rebased the branch.

Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from what @sammy1997 said about separating the js code, Before I approve this, I am going to test this end to end of the whole story taking into account the last 2 PRs.

@mayburgos
Copy link

@anitab-org/portal-maintainers when merging, please update the PR title to reflect our new Commit Style Guidelines.

Copy link

@sakshi1499 sakshi1499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run it locally, works fine for me. I agree with what sammy said , its always good to separate js and not have it in the html file. So please do change it and do follow the commit guidelines.

@ritwickraj78
Copy link
Contributor Author

@SanketDG @sammy1997 API_KEY variable added. Please review it again :)

Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of reviews!

UX question for everyone: Right now, its pretty hard to see the search results. I think there is a scope for improvement here. Maybe we make the map a tad bit smaller? maybe add a loader to the ajax request for visual cue? Looking for ideas.

systers_portal/community/views.py Outdated Show resolved Hide resolved
systers_portal/community/tests/test_views.py Show resolved Hide resolved
systers_portal/community/tests/test_views.py Show resolved Hide resolved
@ritwickraj78
Copy link
Contributor Author

@SanketDG Changes have been made please have a look when you're free :)

Copy link
Contributor

@sammy1997 sammy1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sammy1997
Copy link
Contributor

Merging this PR. cc: @mayburgos @sakshi1499 @ritwickraj78 @SanketDG

@sammy1997 sammy1997 closed this Jun 16, 2020
@sammy1997 sammy1997 reopened this Jun 16, 2020
@sammy1997
Copy link
Contributor

sammy1997 commented Jun 16, 2020

Sorry about that! Accidentally closed it!

@sammy1997 sammy1997 merged commit 2f3c64d into anitab-org:develop Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Location and Zoom In Feature
6 participants