Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Ref: Dropdown Menu Revamped #572

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Ref: Dropdown Menu Revamped #572

merged 3 commits into from
Jul 13, 2020

Conversation

ritwickraj78
Copy link
Contributor

Description

  • Dropdowns no more need clicks to open.
  • List of communities removed from dropdown
  • Change in color just like the Anitab.org website on hovering

Fixes #542

Type of Change:

Delete irrelevant options.

  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested Locally
ezgif com-video-to-gif (2)

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

SanketDG
SanketDG suggested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the first two commits? They seem to represent one feature but are disconnected

SanketDG
SanketDG suggested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will run this locally and we should be good for merge then 💯

requirements/dev.txt Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
systers_portal/GeoLite2-City_20200616/COPYRIGHT.txt Show resolved Hide resolved
systers_portal/meetup/tests/test_views.py Show resolved Hide resolved
systers_portal/meetup/tests/test_views.py Outdated Show resolved Hide resolved
systers_portal/meetup/urls.py Outdated Show resolved Hide resolved
systers_portal/static/js/search_menu.js Outdated Show resolved Hide resolved
systers_portal/templates/meetup/list_meetup.html Outdated Show resolved Hide resolved
@SanketDG SanketDG mentioned this pull request Jul 6, 2020
Closed
7 tasks
sakshi1499
sakshi1499 reviewed Jul 8, 2020
View reviewed changes
Copy link

@sakshi1499 sakshi1499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all no major changes from my side.

systers_portal/meetup/views.py Show resolved Hide resolved
systers_portal/templates/meetup/list_meetup.html Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
SanketDG
SanketDG suggested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to squash your commits!

systers_portal/static/css/style.css Show resolved Hide resolved
systers_portal/templates/base.html Show resolved Hide resolved
@SanketDG SanketDG mentioned this pull request Jul 11, 2020
Open
5 tasks
SanketDG
SanketDG suggested changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments.

As for the location data can you move it to a dedicated folder like locationdata/ instead of keeping at the top level?

.travis.yml Show resolved Hide resolved
requirements/dev.txt Outdated Show resolved Hide resolved
systers_portal/meetup/views.py Outdated Show resolved Hide resolved
systers_portal/meetup/views.py Outdated Show resolved Hide resolved
systers_portal/meetup/views.py Outdated Show resolved Hide resolved
systers_portal/meetup/views.py Outdated Show resolved Hide resolved
systers_portal/meetup/views.py Outdated Show resolved Hide resolved
systers_portal/meetup/views.py Outdated Show resolved Hide resolved
sammy1997
sammy1997 reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@sammy1997 sammy1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @SanketDG @sakshi1499 ?

sammy1997
sammy1997 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@sammy1997 sammy1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sammy1997 sammy1997 merged commit 0750a36 into anitab-org:develop Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sakshi1499 sakshi1499 sakshi1499 approved these changes

@sammy1997 sammy1997 sammy1997 approved these changes

@SanketDG SanketDG SanketDG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Portal Dropdown UX
4 participants
@ritwickraj78 @SanketDG @sammy1997 @sakshi1499