Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

feat: Added Meetup History #593

Merged
merged 4 commits into from
Aug 1, 2020
Merged

feat: Added Meetup History #593

merged 4 commits into from
Aug 1, 2020

Conversation

ritwickraj78
Copy link
Contributor

Description

  • Added Images Model and Resource Fields to Add Meetup and Edit Meetup Form
  • Created past meetup form where user can upload resources and images after meetup is held.
  • Created Past Meetup View to add the resources.

Fixes #548

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

  • All unit tests pass
  • Flake test passes
  • Travis Check successful.
  • Tested locally

Screenshot from 2020-07-10 11-49-38
Screenshot from 2020-07-10 11-49-35
Screenshot from 2020-07-10 11-45-49
Screenshot from 2020-07-10 11-45-23
Screenshot from 2020-07-10 11-45-02

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@ritwickraj78 ritwickraj78 changed the title feat: Added Meetup History (new) feat: Added Meetup History Jul 16, 2020
Copy link

@sakshi1499 sakshi1499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick view, I think we have reviewed Pr on this once, did you close that one? Also, You haven't removed not coming yet.

@ritwickraj78
Copy link
Contributor Author

Just a quick view, I think we have reviewed Pr on this once, did you close that one? Also, You haven't removed not coming yet.

I had closed the eariler one..could you'll please review this one. Then I could make the changes

@ritwickraj78
Copy link
Contributor Author

@SanketDG @sakshi1499 @sammy1997 Can you review this once? It needs to be merged

@SanketDG
Copy link
Contributor

This is mostly reviewed from my side. I wanted a fresh pair of eyes to review this :)

@sammy1997
Copy link
Contributor

@ritwickraj78 can you rebase and resolve the merge conflicts

@ritwickraj78
Copy link
Contributor Author

@SanketDG Could you have a check on the migration files?

@SanketDG
Copy link
Contributor

@ritwickraj78 django-multiupload does not have an official release for >= 2.2
Chive/django-multiupload#31

We have to use the git version like:

git+https://github.com/Chive/django-multiupload.git#egg=multiupload

I have opened an issue Chive/django-multiupload#42

@sammy1997 @sakshi1499 @ritwickraj78 If we want it this way, I will push the changes accordingly.

Please note that this was largely part of the migration work, and that is why I am doing it, because it does not involve any of @ritwickraj78's work.

@ritwickraj78
Copy link
Contributor Author

@SanketDG Changes done. Can you please create the fresh migrations?

Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side except for that piece of code 🙁

Willing to hear what the other mentors are thinking

requirements/prod.txt Show resolved Hide resolved
Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging this!

Copy link

@sakshi1499 sakshi1499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not coming has still not been removed :/ @SanketDG

Copy link

@sakshi1499 sakshi1499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes added in other PR. We can merge this then!

@SanketDG SanketDG merged commit 8970416 into anitab-org:develop Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meetup History Backend
4 participants