-
Notifications
You must be signed in to change notification settings - Fork 209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick view, I think we have reviewed Pr on this once, did you close that one? Also, You haven't removed not coming yet.
I had closed the eariler one..could you'll please review this one. Then I could make the changes |
@SanketDG @sakshi1499 @sammy1997 Can you review this once? It needs to be merged |
This is mostly reviewed from my side. I wanted a fresh pair of eyes to review this :) |
@ritwickraj78 can you rebase and resolve the merge conflicts |
@SanketDG Could you have a check on the migration files? |
@ritwickraj78 We have to use the git version like:
I have opened an issue Chive/django-multiupload#42 @sammy1997 @sakshi1499 @ritwickraj78 If we want it this way, I will push the changes accordingly. Please note that this was largely part of the migration work, and that is why I am doing it, because it does not involve any of @ritwickraj78's work. |
4c2c981
to
e84b8b2
Compare
@SanketDG Changes done. Can you please create the fresh migrations? |
Added Ipware and Scripts Dropdown Revamp Added Meetup History Backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side except for that piece of code 🙁
Willing to hear what the other mentors are thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am merging this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not coming has still not been removed :/ @SanketDG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes added in other PR. We can merge this then!
Description
Fixes #548
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only