This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
feat: compare function added #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sakshi1499 The not coming is removed in this PR. We can merge that one now |
|
Ok ok got it |
sakshi1499
reviewed
Aug 2, 2020
There was a problem hiding this comment.
Some checks are failing can you correct them? @ritwickraj78
SanketDG
previously approved these changes
Aug 3, 2020
|
@sakshi1499 @SanketDG Really sorry. Will make the changes asap |
sammy1997
reviewed
Aug 3, 2020
| percentage_of_similarity = round(float(total_avg) * 100) | ||
| if percentage_of_similarity >= 100: | ||
| percentage_of_similarity = 100 | ||
| return percentage_of_similarity |
There was a problem hiding this comment.
@ritwickraj78 Can you modularize this a bit? And maybe add some comments
sammy1997
previously approved these changes
Aug 10, 2020
There was a problem hiding this comment.
@sakshi1499 @SanketDG Ritwick has made it a bit modular. The rest of it looks good to me. Let's wrap up the reviews and merge these. We are quite behind on these
|
@ritwickraj78 please resolve the merge conflicts |
SanketDG
approved these changes
Aug 10, 2020
sakshi1499
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added compare function to generate similarity score between meetup descriptions
Fixes #560
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
Tried testing with meetup descriptions from meetup.com. Works well
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only