Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line/scatter chart x axis options being overridden #131

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

jasperNura
Copy link
Contributor

Issue

This PR resolves an issue where some of the parameters passed to the charting libraries are overridden. This prevents the use of logarithmic axes or the repositioning of the axis. Theorectically this would also allow a separately defined custom axis to used, but this is untested.

Example

Consider

= line_chart({1 => 0, 10 => -1, 100 => -2, 1000 => -3}, library: { scales: {x: {type: "logarithmic", position: "top"}}})

The current behaviour:
image (1)

Modified behaviour:
image (2)

@ankane ankane merged commit b18d08f into ankane:master Jul 7, 2021
@ankane
Copy link
Owner

ankane commented Jul 7, 2021

Looks great, thanks @jasperNura!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants