Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combo charts #18

Closed
wants to merge 4 commits into from
Closed

Combo charts #18

wants to merge 4 commits into from

Conversation

jokklan
Copy link

@jokklan jokklan commented Apr 10, 2014

First of all, thanks for a awesome library! I use it with your ruby gem and it's much easier then any other charting library i have ever used!

I needed a combination of line and column chart in one of my projects and found that both google and highchart include support for this, without loading any other libraries so i decided to implement support for this into chartkick, so here goes :)

The types is added as an array very similiar to how you set colors:

new Chartkick.ComboChart("chart-1", [["Work", 32],["Play", 1492]], types: ["line", "column"]);

If you think their is a better way to implement this option, will i gladly change and improve it.

Examples:

Highchart:
http://www.highcharts.com/demo/combo

Google Charts:
https://google-developers.appspot.com/chart/interactive/docs/gallery/combochart

jokklan added a commit to jokklan/chartkick that referenced this pull request Apr 10, 2014
@ankane
Copy link
Owner

ankane commented Apr 11, 2014

Thanks, I'll take a look this weekend.

@ankane
Copy link
Owner

ankane commented Apr 16, 2014

Unfortunately, didn't get around to it this weekend, but I'll take a look when I can.

buren added a commit to buren/chartkick.js that referenced this pull request Jul 16, 2015
@ankane
Copy link
Owner

ankane commented Oct 26, 2017

Hey @jokklan, thanks for the PR 👍 and sorry for the long delay. I don't plan to support additional chart types at this time, but will let you know if that changes.

@ankane ankane closed this Oct 26, 2017
jokklan added a commit to jokklan/chartkick that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants