Better place for index_covers method

ankane · Aug 31, 2018 · 7dc97c6 · 7dc97c6
1 parent 9dd8cd2
commit 7dc97c6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/pghero/methods/indexes.rb b/lib/pghero/methods/indexes.rb
@@ -322,6 +322,12 @@ def index_bloat(min_size: nil)
             index_name
         SQL
       end
+
+      protected
+
+      def index_covers?(indexed_columns, columns)
+        indexed_columns.first(columns.size) == columns
+      end
     end
   end
 end
diff --git a/lib/pghero/methods/suggested_indexes.rb b/lib/pghero/methods/suggested_indexes.rb
@@ -217,10 +217,6 @@ def best_index_structure(statement)
         {table: table, where: where, sort: sort}
       end
 
-      def index_covers?(indexed_columns, columns)
-        indexed_columns.first(columns.size) == columns
-      end
-
       # TODO better row estimation
       # https://www.postgresql.org/docs/current/static/row-estimation-examples.html
       def row_estimates(stats, total_rows, rows_left, op)