Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local metadata exiting if file already exists #66

Merged
merged 1 commit into from
May 23, 2024

Conversation

Bryan792
Copy link
Contributor

@Bryan792 Bryan792 commented Aug 15, 2022

Is this logic correct? Sorry, I am not too involved with the project, so unsure.

Here's the git blame: 93f4b27

@Fribb
Copy link

Fribb commented Aug 31, 2022

While trying to fix the issue myself I found a few more things that should be done.

  1. The ReadYTDLInfo Is redundant in the AbstractYoutubeRemoteProvider.cs to the Method in the Utils class
  2. ReadYTDLInfo should use the method in the Utils class as well
  3. Same with the Call in the YTDLSeriesProvider here
  4. The File.Exists you changed should then be moved to the Utils.ReadYTDLInfo for a more centralized usage.

This would then cover everything when the ReadYTDLInfo is used, not only for Movies, Series but also for Image requests (where it also fails)

@jacksgt
Copy link

jacksgt commented Apr 23, 2024

Would be great if we can merge this and get a new release out.

@nalsai
Copy link
Contributor

nalsai commented May 21, 2024

Hey @ankenyr, this fixes a bug introduced in 93f4b27 that prevents getting metadata from info.json files. Could you merge it please?

Thank you.

@ankenyr ankenyr merged commit 80631d4 into ankenyr:master May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants