Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image name with unescaped chars #15890

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

BrayanDSO
Copy link
Member

Fixes

How Has This Been Tested?

Import an image with %20 in its name

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
Copy link
Member

Thanks! Could you drop a needstest for an integration test here

krmanik

This comment was marked as off-topic.

@krmanik
Copy link
Member

krmanik commented Mar 15, 2024

I found that in case of Anki Desktop the files are saved with space but in case of AnkiDroid the files are saved with %20 instead of space. If I manually edit file name in AnkiDroid/collection.media and remove %20 the files are loaded in reviewer also, so issues in adding image to collection also before setup IO editor.

Copy link
Member

@krmanik krmanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue lies somewhere else, approving.

@krmanik krmanik added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Mar 15, 2024
@BrayanDSO BrayanDSO added this pull request to the merge queue Mar 15, 2024
Merged via the queue into ankidroid:main with commit b6bc456 Mar 15, 2024
7 checks passed
@github-actions github-actions bot added this to the 2.18 release milestone Mar 15, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 15, 2024
@BrayanDSO BrayanDSO deleted the fix-img-encode branch May 10, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image with %20 in name can't be rendered
3 participants