Add hook to onDelete in AddonsDialog #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae
reviewed
Jun 14, 2021
qt/tools/genhooks_gui.py
Outdated
| @@ -876,6 +876,11 @@ def on_top_toolbar_did_init_links(links, toolbar): | |||
| args=["dialog: aqt.addons.AddonsDialog", "add_on: aqt.addons.AddonMeta"], | |||
| doc="""Allows doing an action when a single add-on is selected.""", | |||
| ), | |||
| Hook( | |||
| name="addons_dialog_will_delete_addon", | |||
There was a problem hiding this comment.
Suggested change
| name="addons_dialog_will_delete_addon", | |
| name="addons_dialog_will_delete_addons", |
qt/tools/genhooks_gui.py
Outdated
| @@ -876,6 +876,11 @@ def on_top_toolbar_did_init_links(links, toolbar): | |||
| args=["dialog: aqt.addons.AddonsDialog", "add_on: aqt.addons.AddonMeta"], | |||
| doc="""Allows doing an action when a single add-on is selected.""", | |||
| ), | |||
| Hook( | |||
| name="addons_dialog_will_delete_addon", | |||
| args=["dialog: aqt.addons.AddonsDialog", "selected: List[str]"], | |||
There was a problem hiding this comment.
Suggested change
| args=["dialog: aqt.addons.AddonsDialog", "selected: List[str]"], | |
| args=["dialog: aqt.addons.AddonsDialog", "ids: List[str]"], |
qt/aqt/addons.py
Outdated
| @@ -842,6 +842,7 @@ def onViewFiles(self) -> None: | |||
|
|
|||
| def onDelete(self) -> None: | |||
| selected = self.selectedAddons() | |||
| gui_hooks.addons_dialog_will_delete_addon(self, selected) | |||
There was a problem hiding this comment.
Suggested change
| gui_hooks.addons_dialog_will_delete_addon(self, selected) | |
| gui_hooks.addons_dialog_will_delete_addons(self, selected) |
There was a problem hiding this comment.
The hook should probably be run after the 'not selected' and 'askUser' lines, not before it.
ThoreBor
force-pushed
the
delete-addon-hook
branch
from
d845239
to
2f943b6
Compare
|
Okay, you're right. It makes more sense like this. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful for showing a message before deleting an add-on. I would use it for either informing the user that deleting the add-on will only delete the local files, not the data on my server, or for automatically deleting the data before deleting the add-on.
I'm not sure if
"selected: List[str]"is correct, so please let me know if I should change it.