Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some add-on installation errors not being reported #2518

Merged
merged 1 commit into from
May 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions qt/aqt/addons.py
Original file line number Diff line number Diff line change
Expand Up @@ -1184,6 +1184,7 @@ def _download_all(self, force_enable: bool = False) -> None:

def _download_done(self, future: Future) -> None:
self.mgr.mw.progress.finish()
future.result()
# qt gets confused if on_done() opens new windows while the progress
# modal is still cleaning up
self.mgr.mw.progress.single_shot(50, lambda: self.on_done(self.log))
Expand Down