Refactor media sync handling #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dae
commented
Sep 9, 2023
dae
commented
- The media USN is now returned in sync/meta, which avoids an extra round-trip.
- Media syncing is now automatically started by the syncing code at the end of a normal or full sync, which avoids it competing for bandwidth and resources, and avoids duplicate invalid login messages when the auth token is invalid.
- Added a new media_sync_progress() method to both check if media is syncing, and get access to the latest progress.
- Updated the sync log screen to only show the latest line, like AnkiMobile.
- Show media sync errors in a pop-up, so they don't get missed. Use a non-modal pop-up to avoid potential conflicts with other modals.
- The media USN is now returned in sync/meta, which avoids an extra round-trip. - Media syncing is now automatically started by the syncing code at the end of a normal or full sync, which avoids it competing for bandwidth and resources, and avoids duplicate invalid login messages when the auth token is invalid. - Added a new media_sync_progress() method to both check if media is syncing, and get access to the latest progress. - Updated the sync log screen to only show the latest line, like AnkiMobile. - Show media sync errors in a pop-up, so they don't get missed. Use a non-modal pop-up to avoid potential conflicts with other modals.
|
Looking good to me. |
|
Thanks Abdo! |
9 tasks
martinetd
added a commit
to martinetd/anki-sync-server-rs
that referenced
this pull request
Sep 17, 2023
anki 23.09 will include a protocol change (see linked PR) so we need to update the anki base commit and patch. I've aligned the rusqlite dependency to fix rust build, and while I was it aligned a few more where rust would be building an extra version of the lib for anki. Link: ankitects/anki#2647
martinetd
added a commit
to martinetd/anki-sync-server-rs
that referenced
this pull request
Sep 24, 2023
anki 23.10 includes protocol changes (see linked PR, and others) so we need to update the anki base commit and patch. I've aligned the rusqlite dependency to fix rust build, and while I was it aligned a few more where rust would be building an extra version of the lib for anki. Link: ankitects/anki#2647
martinetd
added a commit
to martinetd/anki-sync-server-rs
that referenced
this pull request
Nov 23, 2023
anki 23.10 includes protocol changes (see linked PR, and others) so we need to update the anki base commit and patch. I've aligned the rusqlite dependency to fix rust build, and while I was it aligned a few more where rust would be building an extra version of the lib for anki. Link: ankitects/anki#2647
martinetd
added a commit
to martinetd/anki-sync-server-rs
that referenced
this pull request
Nov 23, 2023
anki 23.10 includes protocol changes (see linked PR, and others) so we need to update the anki base commit and patch. I've aligned the rusqlite dependency to fix rust build, and while I was it aligned a few more where rust would be building an extra version of the lib for anki. Link: ankitects/anki#2647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.