Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misalignment of IO masks in Qt5 when image is vertically long #2829

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix misalignment of IO masks in Qt5 when image is vertically long #2829

merged 2 commits into from
Nov 16, 2023

Conversation

hikaru-y
Copy link
Contributor

@hikaru-y hikaru-y commented Nov 15, 2023 •
edited
Loading

An alternative to c478689.

  • This fixes an issue in Qt5 where the IO masks are misaligned if the image is vertically long.
  • Also, as in Qt6, the IO image is now constrained to fit in the viewport.

@hikaru-y hikaru-y changed the title Fix aspect ratio of IO image not taken into account in Qt5 Fix misalignment of IO masks in Qt5 when image is vertically long Nov 15, 2023
@hikaru-y
Fix misalignment of IO masks in Qt5 when image is vertically long
17bd71f 
Also, as in Qt6, constrain the IO image to fit in the viewport.
@dae
Copy link
Member

dae commented Nov 16, 2023

Thanks Hikaru! I like how this improves things for Qt5 while not risking regressions in Qt6.

@dae dae merged commit 8de5cf9 into ankitects:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hikaru-y @dae