Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sizing issue with scale UI #774

Merged
merged 2 commits into from
Oct 3, 2020
Merged

Conversation

androidpcguy
Copy link
Contributor

Fixes ankitects/help-wanted#18. Height of webview should be the height
of the contents inside it. Previously, scale factors increased fixed
height of the container webview, thus creating empty space (e.g.
at 200% scaling, height of webview was double the height of the inner
HTML page). Now height of webview is always the height of the contained
element.

Fixes ankitects/help-wanted#18. Height of webview should be the height
of the contents inside it. Previously, scale factors increased fixed
height of the container webview, thus creating empty space (e.g.
at 200% scaling, height of webview was double the height of the inner
HTML page). Now height of webview is always the height of the contained
element.
@dae
Copy link
Member

dae commented Oct 3, 2020

@evandrocoan looks like http://repo.msys2.org/msys/x86_64/rsync-3.1.3-1-x86_64.pkg.tar.xz is timing out; I presume things will fix themselves when they get the site back up

@androidpcguy Thanks Akshara! I am actually surprised this works, as I seem to recall that simply setting the height failed in the past. But perhaps a tooltip upgrade or changes in other parts of the code have changed things - I've tested Qt 5.12 and 5.9 and it seems to be doing the right thing.

@dae dae merged commit 41d7459 into ankitects:master Oct 3, 2020
@evandrocoan
Copy link
Contributor

They are trying to reboot the server, but it not coming up. I think they will have to go to it physically: msys2/MSYS2-packages#2171

@evandrocoan
Copy link
Contributor

You can download a rsync now from this mirror: https://mirror.yandex.ru/mirrors/msys2/msys/x86_64/ and put it on the repository https://github.com/ankitects/pyaudio-windows so these problems do not happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate sizing issues when using UI scale
3 participants