Every single word in a JSX block is colored in js2-jsx-mode

[thblt]

The title says it all, really. JSX blocks are completely colorized, including regular HTML text.

The same issue appears in js-jsx-mode

Thanks!

[Hi-Angel]

So, FYI, while working on something else, I took a short stub at it, and the reason you see this turned out to be nil here. The reason it's there in the first place is that documentation about variable color-identifiers:modes-alist says:

If the list includes nil, unfontified words will be considered.

As result, every list for every major mode contain nil in particular.

Per my understanding, this cannot result in proper colorizing, what you see should in fact happen with every mode. Maybe @ankurdave could tell more about it…?

[Hi-Angel]

To be more specific about how nil is causing it: in the affected mode the color-identifiers:scan-identifiers function calls this part (memq (get-text-property (point) 'face) identifier-faces) for every word. And for every word (get-text-property (point) 'face) returns nil, which is stored as one of the faces for the mode, so the whole expression evaluates to t.

[Hi-Angel]

@thblt Yeah, and as a workaround, removing the nil should work.