-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session data, user agents, and CCs. #26
Comments
I think all of those points seem sensible. On Wed, 2 Sep 2015 01:50 Scott Weldon notifications@github.com wrote:
|
I'm not sure how you would determine sensitive session data, though. With On Wed, 2 Sep 2015 07:01 Andreas Lutro anlutro@gmail.com wrote:
|
Cool, I'll get started on some PRs. My idea was to add another config option so that the user may define an array of keys that they want wiped. |
Sounds good. |
Should be completed in 089deb4 - @501st-alpha1 do you want to change your version requirement to dev-master and test it for a bit? The changes will be released as 2.5.0 when I'm confident everything works as it's supposed to. |
I have this running in production for one of the projects. Just got the first notification in, and it seems to be working fine. |
I've gotten some more errors in over the past few days. I have verified that the session wiping works as expected, and the user agent is included in the email. |
Awesome - I'm out traveling so it may be a few days until I can tag a On Thu, 17 Sep 2015 18:54 Scott Weldon notifications@github.com wrote:
|
No prob. |
Completely forgot about this! I just tagged |
I have a couple Laravel 4 projects that implement similar functionality as this package, so I'm looking into switching to this package to make things easier to maintain.
There are three pieces of functionality that are implemented in those projects that this package does not provide:
Session::all()
and thenunset
ing any sensitive data.Would you be open to adding these items? If so, I can probably submit PRs for all three (though I may have questions about how best to implement them).
The text was updated successfully, but these errors were encountered: