on Jira side, search for users by mail, then by name #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_users was looking to a query on the Object of pyclickup.User
the _fetch_pages function will not know how to handle this object, so it will use the string representation: "<pyclickup.User[12345678] 'Firstname Lastname'>", which does not (always) yield proper results.
This change searches first by mail address, which should be quite accurate, then by user name.
Output of variable params in jira.py / search_users()
before:
{'query': <pyclickup.User[12345678] 'Firstname Lastname'>, 'includeActive': True, 'includeInactive': False}
after:
{'query': 'firstname.lastname@domain.tld', 'includeActive': True, 'includeInactive': False}
{'query': 'Firstname Lastname', 'includeActive': True, 'includeInactive': False}